Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed incorrect SignatureFlags.HasRestParameter propagation when combining signatures #58440

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fixed incorrect SignatureFlags.HasRestParameter propagation when combining signatures #58440

wants to merge 3 commits into from
+1,438 −3

Conversation

Andarist
Copy link
Contributor

@Andarist Andarist commented May 5, 2024

fixes #58371

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label May 5, 2024
@Andarist
Copy link
Contributor Author

Andarist commented May 5, 2024

@jakebailey could you prepare a TS playground for this?

@jakebailey
Copy link
Member

@typescript-bot test it
@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 5, 2024 •
edited

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top400 ✅ Started 👀 Results
user test this ✅ Started ✅ Results
run dt ✅ Started ✅ Results
perf test this faster ✅ Started 👀 Results
pack this ✅ Started ✅ Results

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 5, 2024 •
edited

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/161612/artifacts?artifactName=tgz&fileId=3D546827352718F58A299BE07ACE17C344B20098DF792AF548BE062279AED86502&fileName=/typescript-5.5.0-insiders.20240505.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.5.0-pr-58440-3".;

@typescript-bot
Copy link
Collaborator

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the user tests comparing main and refs/pull/58440/merge:

Everything looks good!

@Andarist Andarist mentioned this pull request May 5, 2024
Open
@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - node (v18.15.0, x64)
Errors 30 30 ~ ~ ~ p=1.000 n=6
Symbols 62,154 62,154 ~ ~ ~ p=1.000 n=6
Types 50,273 50,273 ~ ~ ~ p=1.000 n=6
Memory used 193,410k (± 0.96%) 192,279k (± 0.09%) ~ 192,168k 192,643k p=0.471 n=6
Parse Time 1.30s (± 0.40%) 1.30s (± 1.06%) ~ 1.28s 1.32s p=0.437 n=6
Bind Time 0.72s 0.72s ~ ~ ~ p=1.000 n=6
Check Time 9.55s (± 0.39%) 9.53s (± 0.43%) ~ 9.48s 9.60s p=0.260 n=6
Emit Time 2.63s (± 0.47%) 2.64s (± 0.52%) ~ 2.62s 2.66s p=0.183 n=6
Total Time 14.20s (± 0.24%) 14.19s (± 0.32%) ~ 14.14s 14.27s p=0.624 n=6
angular-1 - node (v18.15.0, x64)
Errors 5 5 ~ ~ ~ p=1.000 n=6
Symbols 945,322 945,322 ~ ~ ~ p=1.000 n=6
Types 408,110 408,110 ~ ~ ~ p=1.000 n=6
Memory used 1,222,836k (± 0.01%) 1,222,781k (± 0.00%) ~ 1,222,728k 1,222,839k p=0.173 n=6
Parse Time 6.80s (± 0.83%) 6.77s (± 0.60%) ~ 6.74s 6.85s p=0.334 n=6
Bind Time 1.88s (± 0.56%) 1.88s (± 0.43%) ~ 1.86s 1.88s p=0.720 n=6
Check Time 31.39s (± 0.62%) 31.33s (± 0.41%) ~ 31.16s 31.47s p=0.378 n=6
Emit Time 14.70s (± 0.57%) 14.69s (± 0.52%) ~ 14.60s 14.79s p=0.630 n=6
Total Time 54.77s (± 0.49%) 54.66s (± 0.30%) ~ 54.38s 54.83s p=0.689 n=6
mui-docs - node (v18.15.0, x64)
Errors 5 5 ~ ~ ~ p=1.000 n=6
Symbols 1,957,119 1,957,151 +32 (+ 0.00%) ~ ~ p=0.001 n=6
Types 676,621 676,617 -4 (- 0.00%) ~ ~ p=0.001 n=6
Memory used 1,765,535k (± 0.00%) 1,765,540k (± 0.00%) ~ 1,765,485k 1,765,585k p=0.748 n=6
Parse Time 6.70s (± 0.24%) 6.70s (± 0.36%) ~ 6.68s 6.74s p=0.803 n=6
Bind Time 2.32s (± 0.59%) 2.30s (± 0.45%) ~ 2.29s 2.32s p=0.095 n=6
Check Time 56.35s (± 0.37%) 56.24s (± 0.29%) ~ 55.99s 56.42s p=0.336 n=6
Emit Time 0.14s (± 2.88%) 0.14s ~ ~ ~ p=0.405 n=6
Total Time 65.51s (± 0.32%) 65.38s (± 0.25%) ~ 65.12s 65.55s p=0.297 n=6
self-build-src - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,217,388 1,217,393 +5 (+ 0.00%) ~ ~ p=0.001 n=6
Types 259,008 259,008 ~ ~ ~ p=1.000 n=6
Memory used 2,327,862k (± 0.03%) 2,327,811k (± 0.03%) ~ 2,327,025k 2,328,905k p=0.810 n=6
Parse Time 4.94s (± 0.78%) 4.94s (± 1.08%) ~ 4.89s 5.03s p=0.810 n=6
Bind Time 1.87s (± 1.17%) 1.87s (± 1.14%) ~ 1.85s 1.91s p=1.000 n=6
Check Time 33.49s (± 0.43%) 33.57s (± 0.36%) ~ 33.34s 33.66s p=0.298 n=6
Emit Time 2.60s (± 2.75%) 2.60s (± 0.82%) ~ 2.57s 2.63s p=0.936 n=6
Total Time 42.92s (± 0.47%) 43.01s (± 0.32%) ~ 42.77s 43.13s p=0.471 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,217,388 1,217,393 +5 (+ 0.00%) ~ ~ p=0.001 n=6
Types 259,008 259,008 ~ ~ ~ p=1.000 n=6
Memory used 2,402,844k (± 0.01%) 2,402,847k (± 0.01%) ~ 2,402,495k 2,403,252k p=1.000 n=6
Parse Time 6.17s (± 0.63%) 6.18s (± 0.82%) ~ 6.13s 6.24s p=1.000 n=6
Bind Time 2.06s (± 0.99%) 2.01s (± 1.25%) -0.05s (- 2.51%) 1.97s 2.03s p=0.006 n=6
Check Time 40.09s (± 0.33%) 40.12s (± 0.24%) ~ 39.97s 40.26s p=0.630 n=6
Emit Time 3.14s (± 1.27%) 3.13s (± 1.05%) ~ 3.08s 3.17s p=0.748 n=6
Total Time 51.46s (± 0.32%) 51.45s (± 0.22%) ~ 51.24s 51.55s p=1.000 n=6
self-compiler - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 256,310 256,315 +5 (+ 0.00%) ~ ~ p=0.001 n=6
Types 104,458 104,458 ~ ~ ~ p=1.000 n=6
Memory used 424,923k (± 0.00%) 424,922k (± 0.01%) ~ 424,897k 424,973k p=0.630 n=6
Parse Time 3.37s (± 0.64%) 3.35s (± 0.84%) ~ 3.31s 3.38s p=0.332 n=6
Bind Time 1.29s (± 1.14%) 1.30s (± 1.15%) ~ 1.28s 1.32s p=0.190 n=6
Check Time 17.71s (± 0.19%) 17.77s (± 0.46%) ~ 17.69s 17.91s p=0.261 n=6
Emit Time 1.34s (± 0.87%) 1.34s (± 0.73%) ~ 1.33s 1.35s p=0.673 n=6
Total Time 23.71s (± 0.20%) 23.76s (± 0.33%) ~ 23.67s 23.89s p=0.288 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors 35 35 ~ ~ ~ p=1.000 n=6
Symbols 224,826 224,826 ~ ~ ~ p=1.000 n=6
Types 94,115 94,115 ~ ~ ~ p=1.000 n=6
Memory used 369,950k (± 0.03%) 369,896k (± 0.04%) ~ 369,802k 370,144k p=0.173 n=6
Parse Time 3.50s (± 0.86%) 3.52s (± 0.85%) ~ 3.49s 3.56s p=0.373 n=6
Bind Time 1.94s (± 0.27%) 1.95s (± 0.79%) ~ 1.93s 1.97s p=0.548 n=6
Check Time 19.34s (± 0.40%) 19.30s (± 0.30%) ~ 19.24s 19.40s p=0.374 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 24.78s (± 0.29%) 24.77s (± 0.27%) ~ 24.72s 24.90s p=0.517 n=6
vscode - node (v18.15.0, x64)
Errors 4 4 ~ ~ ~ p=1.000 n=6
Symbols 2,804,834 2,804,799 -35 (- 0.00%) ~ ~ p=0.001 n=6
Types 952,325 952,323 -2 (- 0.00%) ~ ~ p=0.001 n=6
Memory used 2,976,987k (± 0.00%) 2,976,915k (± 0.00%) ~ 2,976,754k 2,977,062k p=0.471 n=6
Parse Time 16.87s (± 0.30%) 16.93s (± 1.13%) ~ 16.80s 17.31s p=1.000 n=6
Bind Time 4.96s (± 0.35%) 4.98s (± 1.66%) ~ 4.92s 5.14s p=0.677 n=6
Check Time 88.50s (± 2.10%) 88.07s (± 0.29%) ~ 87.80s 88.49s p=0.298 n=6
Emit Time 27.90s (± 6.80%) 28.84s (± 1.12%) ~ 28.48s 29.18s p=0.230 n=6
Total Time 138.23s (± 0.21%) 138.82s (± 0.30%) +0.59s (+ 0.43%) 138.42s 139.37s p=0.031 n=6
webpack - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 265,864 265,864 ~ ~ ~ p=1.000 n=6
Types 108,449 108,449 ~ ~ ~ p=1.000 n=6
Memory used 410,535k (± 0.02%) 410,468k (± 0.02%) ~ 410,373k 410,604k p=0.336 n=6
Parse Time 4.76s (± 1.25%) 4.75s (± 0.81%) ~ 4.70s 4.79s p=0.571 n=6
Bind Time 2.07s (± 0.43%) 2.07s (± 0.47%) ~ 2.06s 2.08s p=0.798 n=6
Check Time 21.00s (± 0.32%) 21.00s (± 0.43%) ~ 20.85s 21.11s p=1.000 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 27.84s (± 0.15%) 27.81s (± 0.39%) ~ 27.65s 27.97s p=0.808 n=6
xstate-main - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 524,961 524,961 ~ ~ ~ p=1.000 n=6
Types 179,070 179,070 ~ ~ ~ p=1.000 n=6
Memory used 462,856k (± 0.02%) 462,853k (± 0.01%) ~ 462,760k 462,944k p=0.936 n=6
Parse Time 3.88s (± 0.51%) 3.87s (± 0.22%) ~ 3.85s 3.87s p=0.123 n=6
Bind Time 1.43s (± 1.28%) 1.44s (± 1.16%) ~ 1.42s 1.47s p=0.357 n=6
Check Time 22.49s (± 0.37%) 22.42s (± 0.64%) ~ 22.27s 22.62s p=0.261 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 27.81s (± 0.31%) 27.73s (± 0.52%) ~ 27.57s 27.92s p=0.230 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the top 400 repos comparing main and refs/pull/58440/merge:

Something interesting changed - please have a look.

Details

honojs/hono

4 of 5 projects failed to build with the old tsc and were ignored

tsconfig.json

ueberdosis/tiptap

3 of 8 projects failed to build with the old tsc and were ignored

tests/cypress/tsconfig.json

demos/tsconfig.vue-3.json

demos/tsconfig.vue-2.json

demos/tsconfig.react.json

demos/tsconfig.base.json

@Andarist
Copy link
Contributor Author

Andarist commented May 6, 2024 •
edited

hono change: TS playground (definitely not OK)

@RyanCavanaugh
Copy link
Member

Are you saying hono definitely isn't OK, or the behavior introduced by this PR is definitely not OK?

@typescript-bot typescript-bot added For Backlog Bug PRs that fix a backlog bug and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels May 6, 2024
@Andarist
Copy link
Contributor Author

Andarist commented May 6, 2024

Oops, I can see how my comment was confusing 😅

I meant that the behavior change with my PR was definitely not OK in the hono's case. On the other hand, I think that the behavior change in tiptap was OK - that should report the error. We can compare those 2 playground:

We can see here, on the second one, that the error is reported. On the first one, we pass the same argument - but the function(s) with this parameters were processed by RemoveThis. The resulting functions are conceptually the same as the ones on the second playground.

On top of that, we can remove Extension* types from AnyConfig and AnyExtension to make them unions of 2 types each instead of unions of 3 types each to see the error being reported: TS playground. It's worth noting here that the reported error is not completely OK either as it mentions "Argument of type '[Mark]'" but it should mention "Argument of type 'Mark'".

I pushed out a fix for hono and tests based on tiptap. Could we run extended tests on this and build a new playground?

@jakebailey
Copy link
Member

@typescript-bot test it
@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 6, 2024 •
edited

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top400 ✅ Started 👀 Results
user test this ✅ Started ✅ Results
run dt ✅ Started ✅ Results
perf test this faster ✅ Started 👀 Results
pack this ✅ Started ✅ Results

Andarist
Andarist commented May 6, 2024
View reviewed changes
src/compiler/checker.ts
@@ -31261,12 +31266,13 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
const paramSymbol = createSymbol(
SymbolFlags.FunctionScopedVariable | (isOptional && !isRestParam ? SymbolFlags.Optional : 0),
paramName || `arg${i}` as __String,
isRestParam ? CheckFlags.RestParameter : isOptional ? CheckFlags.OptionalParameter : 0,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding CheckFlags.RestParameter here is based on the similar change from #55625

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 6, 2024 •
edited

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/161632/artifacts?artifactName=tgz&fileId=DA54CA37B9AA73C8097AC2134D6947B577A94B50517AC1BAE0F007CB13CF8F5002&fileName=/typescript-5.5.0-insiders.20240506.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.5.0-pr-58440-13".;

@typescript-bot
Copy link
Collaborator

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the user tests comparing main and refs/pull/58440/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - node (v18.15.0, x64)
Errors 30 30 ~ ~ ~ p=1.000 n=6
Symbols 62,154 62,154 ~ ~ ~ p=1.000 n=6
Types 50,273 50,273 ~ ~ ~ p=1.000 n=6
Memory used 192,348k (± 0.11%) 194,064k (± 1.00%) ~ 192,152k 195,856k p=0.471 n=6
Parse Time 1.30s (± 1.09%) 1.30s (± 0.80%) ~ 1.28s 1.31s p=0.738 n=6
Bind Time 0.72s 0.72s ~ ~ ~ p=1.000 n=6
Check Time 9.54s (± 0.29%) 9.55s (± 0.56%) ~ 9.48s 9.63s p=1.000 n=6
Emit Time 2.64s (± 0.24%) 2.64s (± 0.44%) ~ 2.62s 2.65s p=1.000 n=6
Total Time 14.20s (± 0.28%) 14.20s (± 0.35%) ~ 14.14s 14.27s p=0.627 n=6
angular-1 - node (v18.15.0, x64)
Errors 5 5 ~ ~ ~ p=1.000 n=6
Symbols 945,322 945,322 ~ ~ ~ p=1.000 n=6
Types 408,110 408,110 ~ ~ ~ p=1.000 n=6
Memory used 1,222,819k (± 0.00%) 1,222,813k (± 0.01%) ~ 1,222,691k 1,222,962k p=0.689 n=6
Parse Time 6.81s (± 0.46%) 6.77s (± 0.56%) ~ 6.72s 6.81s p=0.106 n=6
Bind Time 1.88s (± 0.40%) 1.88s (± 0.56%) ~ 1.86s 1.89s p=0.611 n=6
Check Time 31.31s (± 0.62%) 31.31s (± 0.35%) ~ 31.23s 31.53s p=0.936 n=6
Emit Time 14.75s (± 0.51%) 14.70s (± 0.71%) ~ 14.57s 14.85s p=0.423 n=6
Total Time 54.75s (± 0.44%) 54.66s (± 0.37%) ~ 54.43s 55.03s p=0.689 n=6
mui-docs - node (v18.15.0, x64)
Errors 5 5 ~ ~ ~ p=1.000 n=6
Symbols 1,957,194 1,957,194 ~ ~ ~ p=1.000 n=6
Types 676,642 676,642 ~ ~ ~ p=1.000 n=6
Memory used 1,765,682k (± 0.00%) 1,765,673k (± 0.00%) ~ 1,765,645k 1,765,711k p=0.575 n=6
Parse Time 6.70s (± 0.12%) 6.70s (± 0.25%) ~ 6.68s 6.73s p=0.866 n=6
Bind Time 2.32s (± 0.22%) 2.32s (± 0.39%) ~ 2.31s 2.33s p=0.541 n=6
Check Time 56.48s (± 0.24%) 56.37s (± 0.43%) ~ 55.97s 56.70s p=0.336 n=6
Emit Time 0.14s (± 5.69%) 0.14s ~ ~ ~ p=0.405 n=6
Total Time 65.64s (± 0.21%) 65.53s (± 0.36%) ~ 65.13s 65.86s p=0.423 n=6
self-build-src - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,217,450 1,217,455 +5 (+ 0.00%) ~ ~ p=0.001 n=6
Types 259,040 259,040 ~ ~ ~ p=1.000 n=6
Memory used 2,328,391k (± 0.03%) 2,327,944k (± 0.01%) ~ 2,327,607k 2,328,348k p=0.378 n=6
Parse Time 5.00s (± 1.13%) 5.01s (± 1.10%) ~ 4.95s 5.11s p=0.520 n=6
Bind Time 1.87s (± 0.63%) 1.87s (± 1.00%) ~ 1.85s 1.89s p=0.806 n=6
Check Time 33.42s (± 0.52%) 33.33s (± 0.28%) ~ 33.20s 33.43s p=0.378 n=6
Emit Time 2.59s (± 1.14%) 2.65s (± 1.28%) +0.06s (+ 2.32%) 2.59s 2.69s p=0.013 n=6
Total Time 42.90s (± 0.56%) 42.85s (± 0.21%) ~ 42.69s 42.95s p=0.936 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,217,450 1,217,455 +5 (+ 0.00%) ~ ~ p=0.001 n=6
Types 259,040 259,040 ~ ~ ~ p=1.000 n=6
Memory used 2,404,087k (± 0.03%) 2,403,974k (± 0.04%) ~ 2,402,494k 2,404,836k p=0.936 n=6
Parse Time 7.71s (± 0.76%) 7.73s (± 1.83%) ~ 7.60s 7.99s p=0.810 n=6
Bind Time 2.46s (± 0.92%) 2.48s (± 1.39%) ~ 2.43s 2.53s p=0.294 n=6
Check Time 49.40s (± 0.26%) 49.52s (± 0.66%) ~ 49.26s 50.17s p=0.689 n=6
Emit Time 3.79s (± 1.65%) 3.80s (± 2.36%) ~ 3.69s 3.93s p=1.000 n=6
Total Time 63.37s (± 0.11%) 63.55s (± 0.79%) ~ 63.18s 64.53s p=0.873 n=6
self-compiler - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 256,369 256,374 +5 (+ 0.00%) ~ ~ p=0.001 n=6
Types 104,483 104,483 ~ ~ ~ p=1.000 n=6
Memory used 424,987k (± 0.01%) 425,019k (± 0.01%) ~ 424,964k 425,066k p=0.230 n=6
Parse Time 3.37s (± 0.36%) 3.37s (± 0.35%) ~ 3.35s 3.38s p=0.673 n=6
Bind Time 1.30s (± 1.32%) 1.30s (± 0.79%) ~ 1.29s 1.32s p=0.803 n=6
Check Time 17.80s (± 0.33%) 17.77s (± 0.38%) ~ 17.72s 17.90s p=0.334 n=6
Emit Time 1.38s (± 2.19%) 1.37s (± 1.93%) ~ 1.33s 1.40s p=1.000 n=6
Total Time 23.84s (± 0.42%) 23.82s (± 0.22%) ~ 23.78s 23.92s p=0.571 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors 35 35 ~ ~ ~ p=1.000 n=6
Symbols 224,826 224,826 ~ ~ ~ p=1.000 n=6
Types 94,115 94,115 ~ ~ ~ p=1.000 n=6
Memory used 369,921k (± 0.03%) 369,985k (± 0.05%) ~ 369,855k 370,326k p=0.521 n=6
Parse Time 2.83s (± 0.89%) 2.81s (± 0.89%) ~ 2.78s 2.84s p=0.224 n=6
Bind Time 1.58s (± 0.52%) 1.59s (± 0.84%) ~ 1.57s 1.61s p=0.112 n=6
Check Time 15.58s (± 0.36%) 15.57s (± 0.47%) ~ 15.47s 15.68s p=1.000 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 19.98s (± 0.32%) 19.97s (± 0.37%) ~ 19.86s 20.07s p=0.810 n=6
vscode - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 2,807,082 2,807,082 ~ ~ ~ p=1.000 n=6
Types 952,919 952,919 ~ ~ ~ p=1.000 n=6
Memory used 2,978,811k (± 0.00%) 2,978,895k (± 0.00%) ~ 2,978,733k 2,979,041k p=0.298 n=6
Parse Time 16.96s (± 0.26%) 16.96s (± 0.47%) ~ 16.86s 17.07s p=1.000 n=6
Bind Time 5.00s (± 0.50%) 4.98s (± 0.32%) ~ 4.97s 5.01s p=0.402 n=6
Check Time 88.22s (± 0.38%) 88.56s (± 0.31%) ~ 88.12s 88.91s p=0.093 n=6
Emit Time 28.70s (± 0.52%) 28.81s (± 0.70%) ~ 28.53s 29.05s p=0.376 n=6
Total Time 138.87s (± 0.34%) 139.31s (± 0.34%) ~ 138.60s 139.89s p=0.128 n=6
webpack - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 265,864 265,864 ~ ~ ~ p=1.000 n=6
Types 108,449 108,449 ~ ~ ~ p=1.000 n=6
Memory used 410,477k (± 0.02%) 410,489k (± 0.02%) ~ 410,417k 410,577k p=0.689 n=6
Parse Time 4.76s (± 0.87%) 4.74s (± 0.84%) ~ 4.69s 4.79s p=0.334 n=6
Bind Time 2.07s (± 1.08%) 2.06s (± 0.94%) ~ 2.03s 2.09s p=0.456 n=6
Check Time 21.00s (± 0.34%) 21.00s (± 0.25%) ~ 20.95s 21.09s p=0.748 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 27.83s (± 0.19%) 27.80s (± 0.33%) ~ 27.71s 27.92s p=0.575 n=6
xstate-main - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 524,961 524,961 ~ ~ ~ p=1.000 n=6
Types 179,070 179,070 ~ ~ ~ p=1.000 n=6
Memory used 462,878k (± 0.02%) 462,881k (± 0.02%) ~ 462,748k 463,018k p=1.000 n=6
Parse Time 3.87s (± 0.66%) 3.88s (± 0.66%) ~ 3.85s 3.91s p=0.624 n=6
Bind Time 1.43s (± 0.95%) 1.44s (± 1.20%) ~ 1.42s 1.46s p=0.676 n=6
Check Time 22.48s (± 0.55%) 22.37s (± 0.58%) ~ 22.22s 22.54s p=0.149 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 27.79s (± 0.42%) 27.69s (± 0.48%) ~ 27.55s 27.87s p=0.335 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the top 400 repos comparing main and refs/pull/58440/merge:

Something interesting changed - please have a look.

Details

ueberdosis/tiptap

3 of 8 projects failed to build with the old tsc and were ignored

tests/cypress/tsconfig.json

demos/tsconfig.vue-3.json

demos/tsconfig.vue-2.json

demos/tsconfig.react.json

demos/tsconfig.base.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tsc crash with "TypeError: Cannot read properties of undefined (reading 'flags')"
4 participants
@Andarist @jakebailey @typescript-bot @RyanCavanaugh