Remove members from getAccessibleSymbolChain walk #7532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you break apart the commits? GitHub is choking on it, naturally |
mhegazy
force-pushed
the
declarationEmitFixes2
branch
from
c0d7186
to
59f4687
Compare
|
updated to 2 commits. |
|
👍 |
mhegazy
added a commit
that referenced
this pull request
Mar 17, 2016
Remove members from getAccessibleSymbolChain walk
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6642 and #4600
The symbolDisblayBuilder walks up the tree to see if a symbol is accessible by a given name at a given location. It inspects the symbol tables in each enclosing scope (akin to what resolveName does). Previously we considered members in a class or an interface to be in scope. this caused them to incorrectly shadow declarations with the same name. The fix is to remove that.
Most of the changes are to symbol baselines, the change impacts how symbol names are serialized for members. arguably now is better, though either ways the symbol names do not manifest to the user.