Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6319: Add support for --t: es5 and --m es6 #9042

Merged
merged 7 commits into from Jun 10, 2016
Merged

Conversation

mhegazy
Copy link
Contributor

@mhegazy mhegazy commented Jun 9, 2016

Fixes #6319.

@@ -0,0 +1,12 @@
=== tests/cases/compiler/es6modulekindWithES5Target9.ts ===
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code here looks different from tests/baselines/reference/es6modulekindWithES5Target9.js ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. earlier files that i have used and did not delete.

import {a} from "mod";

import * as M from "mod";

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add usage of d, a, M etc to verify exports.identifier is not being emitted

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@mhegazy
Copy link
Contributor Author

mhegazy commented Jun 9, 2016

@sheetalkamat any more comments?

@sheetalkamat
Copy link
Member

👍

@texastoland
Copy link
Contributor

CC @Victorystick!

@Victorystick
Copy link

Woop! This is fantastic news! 🎉 In which stable version can we expect to see these changes?

@mariusschulz
Copy link
Contributor

Yey, great to see this feature! 🎉

@Victorystick The roadmap lists it underneath 2.0.

@texastoland
Copy link
Contributor

It was merged into master so I assume 1.9 though and testable in nightly 1.9.0-dev.20160610-1.0?

@mhegazy
Copy link
Contributor Author

mhegazy commented Jun 11, 2016

correct. today's build should have the fix. it should be shipped as part of the next release (TS 2.0).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants