Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Added es6-babel-react-flux-karma #49

Merged
merged 3 commits into from Nov 2, 2015
Merged

Added es6-babel-react-flux-karma #49

merged 3 commits into from Nov 2, 2015

Conversation

johnnyreilly
Copy link
Contributor

To satisfy #48

var cache = require('gulp-cached');

var targets = [
//{ description: 'FONTS', src: './fonts/*', dest: './dist/fonts' },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Removed stale code.
@johnnyreilly
Copy link
Contributor Author

Done @RyanCavanaugh

@RyanCavanaugh
Copy link
Member

Looks great!

In terms of sample structure, I think it'd be nice to have one or two additional "operations" (state changes) so that it's more clear what's boilerplate and what's part of the functionality. Maybe we can take that as a later PR.

@johnnyreilly
Copy link
Contributor Author

Sounds good! And yes, happy to evolve the sample further in a subsequent PR.

Let me know if you've anything particular in mind and I can put something together. Perhaps allow the creation of a list of people that you could greet? (That would be pretty much TodoMVC type functionality)

mhegazy added a commit that referenced this pull request Nov 2, 2015
Added es6-babel-react-flux-karma
@mhegazy mhegazy merged commit 3e3d454 into microsoft:master Nov 2, 2015
@mhegazy
Copy link
Contributor

mhegazy commented Nov 2, 2015

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants