Skip to content

Commit

Permalink
Upgrader: do not include Micrsoft.Diagnostic.Tracing.EventSource
Browse files Browse the repository at this point in the history
The upgrade verb attempts to copy
Microsoft.Diagnostic.Tracing.EventSource when copying the
ProductUpgrader to the temporary directory to run. If this file is not
present, then the upgrade verb will fail. This following commit removes
this file:

  cbe5787 ("Remove in-proc ETW trace event listener", 2019-02-18)

Clean installs of VFS4G that include this commit will no longer have
this file in the installation directory, and will not be able to
upgrade.

This dll is no longer needed or installed during installation, so we
remove it from the list of files copied over for upgrade.

This is a quick fix - we will also see how to make this less fragile.
One option might be to install "upgrader app" into its own directory
under the VFS For Git installation directory, and then just copy the
directory to the temp location, instead of providing a list of files
that need to be kept in sync.
  • Loading branch information
jamill committed May 10, 2019
1 parent 2258265 commit f107731
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion GVFS/GVFS.Common/ProductUpgrader.cs
Expand Up @@ -36,7 +36,6 @@ public abstract class ProductUpgrader : IDisposable
UpgraderToolConfigFile,
"GVFS.Common.dll",
"GVFS.Platform.Windows.dll",
"Microsoft.Diagnostics.Tracing.EventSource.dll",
"netstandard.dll",
"System.Net.Http.dll",
"Newtonsoft.Json.dll",
Expand Down

0 comments on commit f107731

Please sign in to comment.