Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand information on IProjectTreeModifier #64

Merged
merged 3 commits into from Aug 19, 2015

Conversation

davkean
Copy link
Member

@davkean davkean commented Aug 18, 2015

Also changed scope from ConfiguredProject -> UnconfiguredProject.

Also changed scope from ConfiguredProject -> UnconfiguredProject.
@adrianvmsft
Copy link
Member

👍
I would also add the following note about IProjectTreeModifier2:
"If a tree modifier implements this interface, IProjectTreeModifier2.ApplyModifications will be called instead of the IProjectTreeModifier interface."

@davkean
Copy link
Member Author

davkean commented Aug 19, 2015

Added the additional comment suggested by @adrianvmsft . I don't have rights to merge this.

adrianvmsft added a commit that referenced this pull request Aug 19, 2015
Expand information on IProjectTreeModifier
@adrianvmsft adrianvmsft merged commit 306f82b into microsoft:master Aug 19, 2015
Basic projects), your modifier should act on the children of the project root
(ie when the specified `tree` has a capability of `ProjectTreeCapabilities.ProjectRoot`).
This is because tree modifiers are called to update existing and to initialize new nodes.
For new nodes, there is way to know where it will fit logically into the tree, until it's been
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing word: "there is no way to know..."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants