Fix three bugs found in issue 20 #22

The output of DateTimeStrg() was missing a terminating null. This causes crashes when one tries to includes it later as part of "/* VTT %S compiler %S */".

…licit casting to long This is a variation of the issue with 32-bit long on Windows. On 64-bit Linux, these %li causes casting to 64-bit types. A negative number becomes a large positive value, 4294967296 + number, and generates "Number too large to be parsed, larger than 32,767" errors, when used with the "-a compile everything" option. %li in other files than TTEngine.cpp applies to user messages, instead, and for now, left unchanged. Part of microsoft#20

…pecific macros later. Done with: sed -i -e 's/L"%s"/WIDE_STR_FORMAT/' *.cpp sed -i -e 's/%s"/" WIDE_STR_FORMAT/g' *.cpp sed -i -e 's/L"%s/WIDE_STR_FORMAT L"/g' *.cpp sed -i -e 's/%s/" WIDE_STR_FORMAT L"/g' *.cpp Except one NARROW_STR_FORMAT. Conflicts: src/TTFont.cpp src/vttcompile.cpp

… used Reference: https://docs.microsoft.com/en-us/cpp/c-runtime-library/format-specification-syntax-printf-and-wprintf-functions?view=msvc-160 " The arguments that follow the format string are interpreted according to the corresponding type character and the optional size prefix. Conversions for character types char and wchar_t are specified by using c or C, and single-byte and multi-byte or wide character strings are specified by using s or S, depending on which formatting function is being used. Character and string arguments that are specified by using c and s are interpreted as char and char* by printf family functions, or as wchar_t and wchar_t* by wprintf family functions. Character and string arguments that are specified by using C and S are interpreted as wchar_t and wchar_t* by printf family functions, or as char and char* by wprintf family functions. This behavior is Microsoft-specific. Microsoft-specific: The Z type character, and the behavior of the c, C, s, and S type characters when they're used with the printf and wprintf functions, are Microsoft extensions. The ISO C standard uses c and s consistently for narrow characters and strings, and C and S for wide characters and strings, in all formatting functions. " This is the truncated string problem seen in microsoft#20

Done with: sed -i -e 's/%hs/" NARROW_STR_FORMAT L"/g' *.cpp

Found by: grep -n %li *.cpp | grep -v ErrMsg, | grep -v errMsg, | grep -v error,

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix three bugs found in issue 20 #22

Fix three bugs found in issue 20 #22

Commits on Oct 15, 2021