Skip to content
This repository has been archived by the owner on Dec 7, 2021. It is now read-only.

fix: Fixes issue where user is unable to navigate to new project screen #629

Merged
merged 2 commits into from
Mar 1, 2019

Conversation

wbreza
Copy link
Contributor

@wbreza wbreza commented Mar 1, 2019

Resolves the issue where user is unable to navigate to new project screen from the homepage. This also addresses other strange behavior related to routing in the app.

  • User being navigated to the homepage after creating a connection
  • Refresh application button not working

Resolves AB#17258, 17263, 17058

@wbreza wbreza requested a review from tbarlow12 March 1, 2019 17:17
src/App.tsx Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 1, 2019

Codecov Report

Merging #629 into v2 will increase coverage by 0.07%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff            @@
##               v2    #629      +/-   ##
=========================================
+ Coverage   86.12%   86.2%   +0.07%     
=========================================
  Files         118     118              
  Lines        3417    3415       -2     
  Branches      601     601              
=========================================
+ Hits         2943    2944       +1     
+ Misses        474     471       -3
Impacted Files Coverage Δ
src/App.tsx 84.61% <ø> (ø) ⬆️
src/electron/main.ts 0% <0%> (ø) ⬆️
src/react/components/pages/homepage/homePage.tsx 91.17% <100%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ad667d...9b3ef6b. Read the comment docs.

Copy link
Contributor

@tbarlow12 tbarlow12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's get these parts on the backlog

src/App.tsx Show resolved Hide resolved
@tbarlow12
Copy link
Contributor

Also, is there a way to disable the patch requirement for this commit? Not entirely sure how we test this change...

@wbreza
Copy link
Contributor Author

wbreza commented Mar 1, 2019

@tbarlow12 - Yes i will bypass the patch requirement for this PR.

Copy link
Contributor

@PIC123 PIC123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, looks good!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants