This repository has been archived by the owner on Dec 7, 2021. It is now read-only.
feat: move asset preview to horizontal #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjlittle
reviewed
Aug 22, 2019
|
Just one comment, otherwise good. Glad to see this get merged! |
pjlittle
previously approved these changes
Aug 22, 2019
tbarlow12
previously approved these changes
Aug 22, 2019
elizabethhalper
dismissed stale reviews from tbarlow12 and pjlittle
via
c391ac9
mydiemho
approved these changes
Aug 22, 2019
| @@ -102,8 +106,8 @@ export default class EditorSideBar extends React.Component<IEditorSideBarProps, | |||
| this.props.onAssetSelected(asset); | |||
| } | |||
|
|
|||
| private rowRenderer = ({ key, index, style }): JSX.Element => { | |||
| const asset = this.props.assets[index]; | |||
| private rowRenderer = ({ columnIndex, key, style }): JSX.Element => { | |||
There was a problem hiding this comment.
switching index and key location on purpose?
tbarlow12
added a commit
that referenced
this pull request
Aug 22, 2019
This reverts commit 5e25dc5.
tbarlow12
added a commit
that referenced
this pull request
Aug 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: change sidebar from vertical to horizontal
Moved the vertical asset previewer to be horizontal and at the bottom of the screen. This helps maximize the size of the picture being tagged when it is a landscape photo.
AB#860