Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR to fix broken urls of GitHub Training Lab Link on Introduction to GitHub module #1044

Closed
wants to merge 0 commits into from

Conversation

31Sanskrati
Copy link

Changes

  • URLs change from lab.github.com to skills.github.com

Issues
This will solve #1023 and #1018

@31Sanskrati 31Sanskrati changed the title Fix broken urls of GitHub Training Lab Link on Introduction to GitHub module PR to fix broken urls of GitHub Training Lab Link on Introduction to GitHub module Jan 8, 2023
@saragibby
Copy link
Collaborator

saragibby commented Jan 9, 2023

Thanks for making these updates @31Sanskrati! The same changes were also resolved in #1042 which I believe includes the changes you have here. Would be great to get your 👀 on the updates (https://github.com/microsoft/Web-Dev-For-Beginners/tree/main/1-getting-started-lessons/2-github-basics) to make sure it resolves the items you found.

If you don't spot any updates, we can close this PR as the changes were previously resolved. Thanks!

@saragibby saragibby added the changes requested Requested changes to pull request label Jan 9, 2023
@31Sanskrati
Copy link
Author

I'm sorry for not getting back to you sooner. Yes, the issue is entirely resolved. Thankyou you for reviewing my PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested Requested changes to pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants