Fixed page name styling bug #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrrsharaff
requested review from
dgomezc,
KirillShchetinin,
markAtMicrosoft,
mohannad-abwah,
mvegaca,
sibille,
smmatte and
tejbirsingh
as code owners
trevorNgo
approved these changes
Apr 6, 2019
Kai-Bailey
approved these changes
Apr 8, 2019
markAtMicrosoft
approved these changes
Apr 8, 2019
SahilTara
pushed a commit
that referenced
this pull request
Apr 10, 2019
* T kabail/doc terminology (#160) * Initial draft for the terminology document * Updated image path for terminology document * Second draft of the terminology doc * Third draft of the terminology doc * Reword TODO in terminology doc * Fourth draft of terminology doc * Deployment Docs (#163) * Started docs for deployment * T trngo/telemetry page tracking and Update Cosmos Replacement String Function (#183) * Update package.json ext. details; init telemetry * Adding timed telemetry * Correct constructor args * Telemetry wrapper around functions * static telemetryreporter and interface * Removed Page Tracking In Telemetry * Telemetry to controller via function call wraps * Merge dev controller.ts after merge conflicts * Refactor, and wrap azure deployments * Seperated Startup and Wizard Session Time * Extract string eventName to constants * Fix naming * promisify azure deploys * Controller wrapped, telemetry ready for page timer * merged engine sync fix into telem * Fixed validator * Fixed env path * Cleaned up some of the controller * Fixed sync bug where controller didn't retry sync on fail * Applied a few changes * pass vscode context to getPackageInfo * Removed redundant promise<any> * Readd startExtTimer, extract env replace to func * Fix syncAttemptCount * Minor changes; move startTime to Telemetry * Update constants file for consistent event names * Wrap Azure Login Status Check * max page name length is 50 (#207) * added sql support for mocks (#180) * added sql support for templates * added support for _id with SQL in mocks * Renamed Version Token for Local Builds (#213) * renamed token for local builds * token update * Create new summary page (#206) * add layout for new summary page add services tiles to summary page * add ability to remove pages from review and summary page * refactor selections into summary section component * change page names from summary page * allow function name changes from summary page * add page.id to page list to fix rendering issue * T kabail/remove material dependencies (#203) * Removed material-ui dependencies and old images * Converted .js files to .jsx * Removed empty arrow function in props * add prettier styling and update release notes (#215) * Fix for deployment (#214) * fixed storage name bug (#208) * fixed storage name bug * Undo changed version number * moved constants, added note for broken kudu service * Added process kill fix (#216) * Added process kill fix for windows * T trngo/telemetry page message sent from wizard for tracking (#211) * Wrap Azure Login Status Check * Added Page Switch Payload Message from wizard * Adding consistent page tracking even on last page * Update Release notes * removed console log * Moving extensioncommands to constants file * Update Release notes * Update RELEASENOTES.md Revert Release notes md * updated README with app image (#218) * updated README with app image * edit readme with latest VSIX install instructions * Changed cosmosOptions to cosmosDB (#234) Fixed cosmos internal name bug by changing the constant used * Welcome Page Component/Summary Page Fixes (#219) * Added welcome page to sidebar * Fixed styling on summary page * refactor output path and project name components into separate components with updates on changes. * open azure functions & cosmos modal from sidebar using edit button. * Limited wizard to 1 cosmos resource. * add ability to open modals from summary page * add reorder icon * added robust deployment for functions, refactored creation codebase (#242) * added robust deployment for functions, refactored creation codebase * removed function bug note from releasenotes * Update RELEASENOTES.md * Delete 0.0.0.0 * fixed PR comments * Centralized express error handling (#243) Centralized Express Error Handling * Fixed typo in env vars (#254) * T keng/post gen modal (#245) * add initial post-gen modal layout * create reducers and selectors for template generation status * set up actions and reducers to communicate generation status add action for updating generation status add isGenerated action on extension and client redesign generation status object on wizard * Send service status to wizard * add generation complete message when generation done receive callback from extension when generation completes * get status message to show on post-gen modal * fix path output bug to support windows fix generation directory output * return output path from server * ui fixes so spinner disengages if templates generate remove console log * add logic to see if cosmos deployed * add logic to detect if services are deployed in post-gen * add to release notes * created selectors to reduce code redundancy * fix small ui bug where cosmos shows up twice * fix bug that did not send cosmos deployment status to client * revert readme * extension-i18n (#244) * added localize calls, added gulpfile * added en strings * removed locale 'out' dirs from ignore, added internal compile * removed README changes from extension PR * ignored package.nls.*.json * file format for localization * ignored package.nls.*.json * removed INSTALL.md * T keng/rearrange pages fix (#250) * save page count to redux instead of component * autoselect blank page as an option in redux page count * dandua98/readme cleanup (#276) * cleaned up README * fixed relative links * Delete 0.0.0.0 * Update getting-started-developers.md * Possible fix for server disposal (#263) * Initial version of bootstrap templates (#253) * Initial version of bootstrap templates * Fixed const bug * Fixed loremipsum dupe bug * base setup for wizard internationalizations, moved component strings (#255) * base setup for wizard internationalizations, moved component strings * Update manageTranslations.js * added build status (#282) * fix for blank page and page icons displaying (#281) * Update Release Notes (#274) * fixed README install link * condensed imports and prepend module alias (#275) * Output path validation (#272) Added Output Path Validation to Welcome page * Project Name Validation (#283) Added project name validation * Added fix for linux (#286) * T kabail/wizard detail image (#299) Added screenshots to the detail pages. * Fixed bug (#314) * Resolved bug with disappearing footer in the details page (#312) Resolved bug with disappearing footer in the details page * Added initial version of versions to frameworks (#322) * Added initial version of versions * Added node version, and fixed default version * dandua98/react intl for containers (#309) * internationalized azure containers * internationalization support to azureSubscriptions-PostGen containers * finished making containers internationalizable * fixed output path * Templates now have Mongo + Sql support rather than just mongo (#317) * Added internal names specific to Mongo/SQL * Changed templates to support Mongo identity * Added sql templates * Updated docs to be inline with sql rather than mongo * T trngo/controller tech debt (#313) * No code added, just rearranged * Moving Azure Services to one folder * Migrated performLogin * handle error messages in performLogin + lint * Renaming and adding subscriptionItem caching * Update AzureServices by migrate subscription data * Moved cosmos functions validate to azureservice * moved promptUserForCosmosReplacement of env file * Moved deploycosmos and deployfunctions * Removed Unused Functions * Removed unused imports * Moved Resource Group Items * Removed unused import * Removed email property from azureServices * Removed advertisements (#334) * Removed advertisements * T kabail/azure functions filepath (#342) * Fixed Fucntions filepath and Cosmos Templates * fixed functions and cosmos paths * Resolved svg spacing in the detail page (#329) * Added links to create new (#331) Added links to "Create New" in modals * Add licenses and authors to frameworks and pages (#327) * add licensing message to footer play with styling and fonts * Added licenses and updated descriptions * fix details spacing with grid layout remove frontend and backend mock data * remove backend and frontend initial state and add license selectors * add framework licenses to rightsidebar fix styling for 'a' tags and add more licenses * add authors to details page * minor code styling changes * add authors to summary tile cards * fix spacing for showing pages * fix displaying versions in details page * add to translations file * fix license message so that it only shows up when frameworks was displayed * T trngo/removed bad practice on name validation (#324) * No code added, just rearranged * Moving Azure Services to one folder * Migrated performLogin * handle error messages in performLogin + lint * Renaming and adding subscriptionItem caching * Update AzureServices by migrate subscription data * Moved cosmos functions validate to azureservice * moved promptUserForCosmosReplacement of env file * Moved deploycosmos and deployfunctions * Details page page bug fix (#352) * Fixed details button adding pages * Changed path to constant * T keng/consistent naming (#332) * change title to justify left * fix welcome page naming * fix rightsidebar styling * replace strings in localization files * Changed Acorn to Web Template Studio in extension + templates (#344) * Implement Reactive Sign out (#335) * Fixed bug to fire off logout command * Adjust message format to wizard cosmos modal * change name and output component on summary page to a tile (#343) * change name and output component on summary page to a tile * Disable Modal Drop Downs until Subscription is Selected (#346) * Fixed bug * Disabled button * Removed react tool tip * Change opacity on disable for Cosmos Modal * Disable dropdowns in Azure Functions model * Minor styling with disabled drop downs * Dandua98/react intl additional (#340) * internationalized azure containers * internationalization support to azureSubscriptions-PostGen containers * finished making containers internationalizable * moved constants to react-intl * fix type errors with modals preventing rendering * add messages to wizard selection selectors * add intl messages for service selections * add additional intl messages for additional modal info * remove required version prop * Fixed page name styling bug (#348) * T keng/add intro (#366) * STARTCOMMIT - Add About Component and expose version endpoint from extension * styling changes * version numb sent to client on launch * add translation changes * Hot fix, propogate to validate function name (#370) * provide null check if an error doesn't exists (#376) * provide null check if an error doesn't exists * revert change on summarytile * Added spinner + debouncing to azure modals (#354) * Added spinner + debouncing to azure modals * Fixed spinner loading on modal load * Fixed pixel centering of spinner * Added temp fix for azure function errors * Env file replacement pop up fix for Sql api (#349) * T keng/feedback button (#356) * fix intl bug that doesn't pass down props to injected components * change feedback link * add translations update * Added link to create account (#364) * T keng/new services design (#353) * fix initial styling for service cards * baseline sizing for azure services * Properly pass function data to the engine + created functions templates (#355) * Send Azure Functions data to the engine * Added function templates * Fixed master detail link bug * Changed project acorn to web template studio * Reset resource group selection on subscription change in Azure Functions and Cosmos Modals (#358) * Extracted Validation out of Modals * Fixed on subscriptions reset bug, unlimited validation bug and resource group refresh bug * Api module refactor (#351) * Started refactoring api module * Changed var to let * Finished off refactoring api module * Allow page names to have spaces but project name cannot (#379) * Allow page names to have spaces but project name cannot * T keng/add azure details (#372) * add details to azure login card * add markdown url * intl azure data * add additional translations * create logic to render markdown as a formatted or unformatted string for intl * Specify vscode version in instructions (#410)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #205