Update print preview when switching printers #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you switch printers the print preview doesn't update until you change another property like Orientation. This is noticeable when switch from something like print to PDF which has no margins to a physical printer that does. (bug #292) Fix is to listen to OptionChanged and invalidate the preview when an event with a null OptionId is raised.
|
Hi @mtaron, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution! TTYL, AZPRBOT; |
|
I took a look, as well. Looks good to me. Good catch! |
|
Thanks! I don't have write access so one of you guys will need to merge the pull request. |
damyanp
added a commit
that referenced
this pull request
Mar 4, 2016
Update print preview when switching printers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you switch printers the print preview doesn't update until you change
another property like Orientation. This is noticeable when switch from
something like print to PDF which has no margins to a physical printer
that does. (bug #292)
Fix is to listen to OptionChanged and invalidate the preview when an
event with a null OptionId is raised.