Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in +[SCNetworkReachability _checkGlobalReachability] #1786

Closed
triplef opened this issue Jan 24, 2017 · 1 comment
Closed

Crash in +[SCNetworkReachability _checkGlobalReachability] #1786

triplef opened this issue Jan 24, 2017 · 1 comment

Comments

@triplef
Copy link
Contributor

triplef commented Jan 24, 2017

We’re seeing multiple crashes like the following.

Any idea why -[WNCConnectionProfile getNetworkConnectivityLevel] might be throwing an exception here? Should this be wrapped in a try/catch?

CPP_EXCEPTION_e06d7363_ObjCUWP_Windows_Networking.dll!-[WNCConnectionProfile_getNetworkConnectivityLevel]

0	kernelbase	RaiseException	0x62
1	vcruntime140_app	_CxxThrowException	0x65
2	libobjc2	objc_exception_throw	0x4BA
3	objcuwp_windows_networking	wil::details::ReportFailure	0x153
4	objcuwp_windows_networking	wil::details::ReportFailure_Hr	0x24
5	objcuwp_windows_networking	wil::details::in1diag5::_Objc_Throw_Hr	0x20
6	objcuwp_windows_networking	-[WNCConnectionProfile getNetworkConnectivityLevel]	0x6B
7	systemconfiguration	+[SCNetworkReachability _checkGlobalReachability]	0x25
8	systemconfiguration	+[SCNetworkReachability _networkStatusChanged]	0x17
9	systemconfiguration	__35+[SCNetworkReachability initialize]_block_invoke	0x13
10	objcuwp_windows_networking	WNCNetworkStatusChangedEventHandler_shim::Invoke	0x3D
11	windows_networking_connectivity	Windows::Internal::Details::GitInvokeHelper_Windows::Networking::Connectivity::INetworkStatusChangedEventHandler,Windows::Internal::GitPtr,1_::Invoke	0x48
12	windows_networking_connectivity	Microsoft::WRL::InvokeTraits_-2_::InvokeDelegates__lambda_5ea70f5f51dc6110b429d66ede34b4e1_,Windows::Networking::Connectivity::INetworkStatusChangedEventHandler_	0x46
13	windows_networking_connectivity	Microsoft::WRL::EventSource_Windows::Networking::Connectivity::INetworkStatusChangedEventHandler,Microsoft::WRL::InvokeModeOptions_-2_ _::DoInvoke__lambda_5ea70f5f51dc6110b429d66ede34b4e1_ _	0x43
14	windows_networking_connectivity	Windows::Networking::Connectivity::CEventDispatcher::_InvokeListeners	0x34
15	windows_networking_connectivity	Windows::Networking::Connectivity::CEventDispatcher::_InvokeListenersCallback	0x46
16	ntdll	TppWorkpExecuteCallback	0x153
17	ntdll	TppWorkerThread	0x396
18	kernel32	BaseThreadInitThunk	0x24
19	ntdll	__RtlUserThreadStart	0x2F
20	ntdll	_RtlUserThreadStart
@rajsesh
Copy link
Contributor

rajsesh commented Jan 24, 2017

It is not clear that getNetworkConnectivityLevel would fail when handling a network status change event, which is what is happening here. Looking into this, and yes, if the failure can happen, then this could be a handled exception.

rajsesh pushed a commit to rajsesh/WinObjC that referenced this issue Jan 24, 2017
these and treat the connection status as 'not connected'.

Fixes microsoft#1786
@rajsesh rajsesh self-assigned this Jan 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants