Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1712.1 release #2825

Merged
merged 8 commits into from
Dec 18, 2017
Merged

1712.1 release #2825

merged 8 commits into from
Dec 18, 2017

Conversation

MSFTFox
Copy link
Member

@MSFTFox MSFTFox commented Dec 18, 2017 •
edited by DHowett-MSFT
Loading

Merge develop into master.

Updates:

  • libdispatch was updated to support the dispatch_queue_specific APIs
  • OSSpinLock and friends were made available
  • Bundles will now load localized resources appropriate for the user's preferred languages

This change is Reviewable

MSFTFox and others added 8 commits November 17, 2017 14:46
@MSFTFox
Implement libdispatch queue_specific* and expose dispatch_barrier
c28623f
@MSFTFox
Check in libdispatch binaries with queue_specific*
7255099
@MSFTFox
Implement new tests for dispatch_queue_specific*
be3a820
Merge remote-tracking branch 'upstream/master' into develop
015afb8
@MSFTFox
Implement OSSpinLock in WOCStdLib (#2820)
6db6744 
* Implement OSSpinLock in WoCStdLib

* Add a test for OSSpinLock utilizing libdispatch

Fixes #2709

* Address PR Feedback

* Remove file global variables.

* Manage resources more correctly.
@MSFTFox
Fix NSNullTests comparison between NSNull null and kCFNull (#2821)
d68ea60
@MSFTFox
Update libdispatch to use asynchronous destructor calls (#2822)
e1fae88 
* Update libdispatch specific destructor calls to run in async

* Update dispatch tests for asynchronous specific destructor

* Update destructor test semaphores.
@MSFTFox
Fix NSLocalizedString and Add Localization Tests (#2824)
22fb297 
* Fix NSLocalizedString and add new tests

* Address CR Feedback.

* Forgot to change to StringByAppendingPath

* Nevermind. ASSERT_OBJCEQ does indeed work.

* Address feedback.

* Address feedback.
@DHowett-MSFT
Copy link

nit: please rename this pull request
not a nit: please reword the entire body of the pull request before you merge it, it's riddled with curiosities.

@DHowett-MSFT
Copy link

(When Raj does develop -> master merges, he names the pull request after the release name, as in #2814.)

@MSFTFox
Copy link
Member Author

MSFTFox commented Dec 18, 2017

Oh, I was following how he named the merge from master into develop earlier.

@MSFTFox MSFTFox changed the title Merge remote-tracking branch 'upstream/develop' into master 1712.1 release Dec 18, 2017
@DHowett-MSFT
Copy link

further nits:

  • libdispatch was updated to support the dispatch_queue_specific APIs
  • OSSpinLock and friends were made available (not OSSpingLock)
  • Bundles will now load localized resources appropriate for the user's preferred languages.

@MSFTFox MSFTFox merged commit 678db03 into master Dec 18, 2017
MSFTFox added a commit that referenced this pull request Jan 5, 2018
@MSFTFox
Merge pull request #2825 from develop
04bf9f3 
1712.1 release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett-MSFT DHowett-MSFT DHowett-MSFT approved these changes

@rajsesh rajsesh Awaiting requested review from rajsesh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MSFTFox @DHowett-MSFT