Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tile carousel on home page + tiles for community & accessibility #1131

Merged
merged 8 commits into from
Jan 31, 2023

Conversation

gregwoo-microsoft
Copy link
Contributor

  • Adds a reference to the Community Toolkit
  • Creates better integration between our various dev tools
  • Created a folder for all of the header tiles

image

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@gregwoo-microsoft
Copy link
Contributor Author

FYI @niels9001

<controls:HeaderTile Title="Windows Design" Source="/Assets/HomeHeaderTiles/style-1x.png" Link="https://docs.microsoft.com/windows/apps/design/"/>
<controls:HeaderTile Title="WinUI Repo" Source="/Assets/HomeHeaderTiles/githubTile.png" Link="https://github.com/microsoft/microsoft-ui-xaml"/>
<controls:HeaderTile Title="Template Studio" Source="/Assets/HomeHeaderTiles/template_studio.png" Link="https://marketplace.visualstudio.com/items?itemName=TemplateStudio.TemplateStudioForWinUICs"/>
<controls:HeaderTile Title="Community Toolkit" Source="/Assets/HomeHeaderTiles/toolkit.png" Link="https://apps.microsoft.com/store/detail/windows-community-toolkit-sample-app/9NBLGGH4TLCQ"/>
Copy link
Collaborator

@niels9001 niels9001 Dec 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: Actually no, linking directly to the Gallery app (so hopefully it opens directly) makes most sense :)

@gregwoo-microsoft
Copy link
Contributor Author

@niels9001 @chingucoding let me know what you think, I added a new flipview/carousel functionality + a new accessibility tile

@marcelwgn
Copy link
Collaborator

I think we should recalculate the number of items inside the FlipView based on the width of the app and maybe also use a PipsPager at the bottom? Let me know what you think @gregwoo-microsoft.

@gregwoo-microsoft
Copy link
Contributor Author

Yeah that is a great idea @chingucoding. I can look to add a PipsPager tomorrow. Do you know how to adjust the FlipView based on the app's width?

@marcelwgn
Copy link
Collaborator

I think the best way would be to listen to the FlipViews SizeChanged event and recalculate how many items to show based on that.

@niels9001
Copy link
Collaborator

@gregwoo-microsoft @chingucoding I've created the following: gregwoo-microsoft#2

This uses a scrollviewer and will show the scroll buttons whenever the is more content to scroll to. This is also how Store handles its screenshots section and is maybe easier than moving items around in a FlipView😊? (Would be nice to have some sort of adaptive FlipView that can stretch to show more content vs. flipping if not).

Tiles gallery

@marcelwgn
Copy link
Collaborator

That would also work but I think having a PipsPager and FlipView for this would look better even if it is more complicated to set up. Maybe we could even let it switch the view every x seconds? What are your thoughts @gregwoo-microsoft @niels9001 ?

@niels9001
Copy link
Collaborator

That would also work but I think having a PipsPager and FlipView for this would look better even if it is more complicated to set up. Maybe we could even let it switch the view every x seconds? What are your thoughts @gregwoo-microsoft @niels9001 ?

Hmm.. looking at the Store homepage carousel and screenshots gallery on the PDP, they seem to favor a ScrollViewer vs. a FlipView. My worry with a FlipView is that you might end up with e.g. 4 items on the first item and 2 on the second item? Not sure if that'd look great. Also discoverability might not be the greatest as the PipsPager might be missed?

I'd say, in the end this might be an interesting opportunity to recreate something like the Store carousel - this would also allow the landingspage to be more engaging by providing big images with additional information :).

@marcelwgn
Copy link
Collaborator

Alright, lets do that then. Not sure about the big pictures in the future but I think we'll figure that out then.

@gregwoo-microsoft
Copy link
Contributor Author

Love the change @niels9001. Thanks for implementing that. I just merged your PR.

@gregwoo-microsoft gregwoo-microsoft changed the title Added new tile for the Community Toolkit New tile carousel on home page + tiles for community & accessibility Jan 24, 2023
@niels9001
Copy link
Collaborator

@gregwoo-microsoft Can we get this in?

@gregwoo-microsoft gregwoo-microsoft merged commit 0d4fc10 into microsoft:main Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants