Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding CopyButton #1295

Merged
merged 3 commits into from
May 18, 2023
Merged

Adding CopyButton #1295

merged 3 commits into from
May 18, 2023

Conversation

niels9001
Copy link
Collaborator

@niels9001 niels9001 commented May 17, 2023

This PR solves the current issues:

  • We had multiple buttons to copy content to with different styles.
  • The teaching tip didn't auto-hide correctly after clicking the button.
  • There's now an easy to use CopyButton that shows the same animation as Snipping Tool and handles the narrator announcement.
  • Addressing: Typograpy page: accessibility for Copy button #1247

Animated button

@niels9001 niels9001 requested a review from karkarl May 17, 2023 16:13
@niels9001 niels9001 linked an issue May 17, 2023 that may be closed by this pull request
@niels9001 niels9001 changed the title Adding copybutton animation Adding CopyButton May 17, 2023
Copy link
Collaborator

@marcelwgn marcelwgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea, LGTM!

@marcelwgn marcelwgn merged commit 2722266 into main May 18, 2023
Copy link
Contributor

@Jay-o-Way Jay-o-Way left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HorizontalAlignment (right) and Visibility are not yet consistent across the app (at least for Typography and Colors page)

Style="{StaticResource SubtleButtonStyle}"
ToolTipService.ToolTip="Copy Style to clipboard"
Margin="4,2,8,0"
ToolTipService.ToolTip="Copy to clipboard"
Visibility="Collapsed" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(correct me if i'm mistaken, but) This property makes it so that it still is hidden by default. That isn't consistent across all the examples: usually it's always visible.

@niels9001 niels9001 deleted the niels9001/copybutton branch October 26, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typograpy page: accessibility for Copy button
3 participants