Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Pivot control's description #1508

Merged

Conversation

AndrewKeepCoding
Copy link
Contributor

@AndrewKeepCoding AndrewKeepCoding commented Mar 19, 2024

Description

Change Pivot control's description back to plain text since html tags are not supported here.

Motivation and Context

Closes #1504

How Has This Been Tested?

Run the app and confirmed that the Pivot description doesn't have html tags.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@marcelwgn
Copy link
Collaborator

Thank you for fixing this @AndrewKeepCoding

@Jay-o-Way
Copy link
Contributor

@marcelwgn please link the issue, and look into the fact if it's really deprecated or not. I don't believe it is.

@marcelwgn
Copy link
Collaborator

Thanks for mentioning the issue @Jay-o-Way. Pivot is deprecated as indicated here and you should not use it anymore: https://learn.microsoft.com/en-us/windows/apps/design/controls/pivot#is-this-the-right-control

@Jay-o-Way
Copy link
Contributor

Yeah, but, what if that doc is outdated? It hasn't been changed in "almost" a year, roughly around the time things were not definitive...

@marcelwgn
Copy link
Collaborator

marcelwgn commented Mar 20, 2024

Even if we assume the docs are outdated, I find it hard to believe that the sentence "Pivot is deprecated, please use SelectorBar" would be outdated given that Sidebar only was released with WinUI 1.5 a few weeks ago. Also see #1467 where this was added 2 weeks ago.

@karkarl
Copy link
Collaborator

karkarl commented Mar 21, 2024

/azp run

@karkarl
Copy link
Collaborator

karkarl commented Mar 21, 2024

Pivot was initially developed for Windows Phone, so a lot of functionality is specific to phone / touch scenarios. As such, we developed SelectorBar with a focus on perf, and will be recommending developers to use this control from now on.

So yes, Pivot is definitely being deprecated. :)

@karkarl karkarl merged commit d664b72 into microsoft:main Mar 21, 2024
2 checks passed
@AndrewKeepCoding AndrewKeepCoding deleted the fix-pivot-control-description branch March 21, 2024 23:52
karkarl added a commit that referenced this pull request May 21, 2024
<!--- Provide a general summary of your changes in the Title above -->

## Description
<!--- Describe your changes in detail -->
I ate my [own
words](#1508 (comment))
- Pivot is **NOT** deprecated. It is instead "not recommended".

Updated pivot description to what is in the [dev
docs](https://learn.microsoft.com/en-us/windows/windows-app-sdk/api/winrt/microsoft.ui.xaml.controls.pivot?view=windows-app-sdk-1.5).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pivot text not formatted
4 participants