Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set URI source version numbers dynamically to simplify maintenance #1523

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Set URI source version numbers dynamically to simplify maintenance #1523

merged 2 commits into from
Apr 3, 2024

Conversation

Scottj1s
Copy link
Member

@Scottj1s Scottj1s commented Apr 3, 2024

Replace hardcoded version numbers embedded in source URIs with associated WASDK version numbers.

marcelwgn
marcelwgn approved these changes Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@marcelwgn marcelwgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea @Scottj1s, LGTM.

Nit: Not sure if we really need to account for WinUI 3 Release 2.X but guess it doesn't hurt.

@Scottj1s
Copy link
Member Author

Scottj1s commented Apr 3, 2024

/azp run

@Scottj1s Scottj1s merged commit c3cf8db into main Apr 3, 2024
2 checks passed
@Scottj1s Scottj1s deleted the user/sjones/source_link_version branch April 3, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelwgn marcelwgn marcelwgn approved these changes

@ShashankNay ShashankNay ShashankNay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Scottj1s @marcelwgn @ShashankNay