Fix: No contrast of the CopyButton in the color guidance page #1554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karkarl
requested changes
Jun 5, 2024
|
Here's a weird idea? What would happen if we remove all of this manual work and reset the button to defaults?! 🤓 |
|
...On-topic...
|
|
I figured out a way, just set |
|
/azp run |
karkarl
approved these changes
Jun 19, 2024
karkarl
pushed a commit
that referenced
this pull request
Jul 15, 2024
<!--- Provide a general summary of your changes in the Title above --> ## Description The `CopyButton`'s `PointerOver` state is bind to `ButtonPressedForeground` brush, and it will be white in a dark theme, making the button invisible when hoveed in that page.  It should be bind to its `Foreground` so it remains invisible. So after this fix:  ## How Has This Been Tested? Manual ## Screenshots (if appropriate): ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change)
karkarl
pushed a commit
that referenced
this pull request
Jul 15, 2024
<!--- Provide a general summary of your changes in the Title above --> ## Description The `CopyButton`'s `PointerOver` state is bind to `ButtonPressedForeground` brush, and it will be white in a dark theme, making the button invisible when hoveed in that page.  It should be bind to its `Foreground` so it remains invisible. So after this fix:  ## How Has This Been Tested? Manual ## Screenshots (if appropriate): ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
CopyButton'sPointerOverstate is bind toButtonPressedForegroundbrush, and it will be white in a dark theme, making the button invisible when hoveed in that page.It should be bind to its
Foregroundso it remains invisible. So after this fix:Motivation and Context
How Has This Been Tested?
Manual
Screenshots (if appropriate):
Types of changes