Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve version info, vsix installation, and update building locally documentation #1190

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

middlemose
Copy link
Contributor

Additional improvements to the maintenance and documentation of the CI pipeline.

  • Improved the vsix installer procedure by auto resolving the latest vsix, added additional logging, and removed sourcing of environment variables.
  • Added NuGet package version and vsix version to the sample set build output.
  • Updated the documentation for building locally by removing hardcoded version and improved the steps to install the WDK vsix extension from Visual Studio.

@middlemose
Copy link
Contributor Author

middlemose commented Jun 25, 2024

Install vsix output:

**********************************************************************
** Visual Studio 2022 Developer PowerShell v17.10.3
** Copyright (c) 2022 Microsoft Corporation
**********************************************************************
---> Downloading vsix version: 10.0.26100.1
Downloaded VSIX Version: 10.0.26100.1
<--- Download complete
---> Configuring build environment...
Installed VSIX Version: 10.0.26100.1
<--- Configuration complete

@middlemose
Copy link
Contributor Author

Build info output:

Build Environment:          GitHub
Build Number:               26100
Nuget Package Version:      10.0.26100.1
WDK VSIX Version:           10.0.26100.1
Samples:                    132
Configurations:             1 (Release)
Platforms:                  1 (x64)
InfVerif_AdditionalOptions: /samples
Combinations:               132
LogicalProcessors:          4
ThrottleFactor:             5
ThrottleLimit:              20
WDS_WipeOutputs:            
Disk Remaining (GB):        144.584812164307
T: Combinations
B: Built
R: Build is running currently
P: Build is pending an available build slot
S: Built and result was 'Succeeded'
E: Built and result was 'Excluded'
U: Built and result was 'Unsupported' (Platform and Configuration combination)
F: Built and result was 'Failed'
O: Built and result was 'Sporadic'
Building all combinations...

@middlemose middlemose marked this pull request as ready for review June 25, 2024 21:05
@middlemose middlemose requested a review from a team as a code owner June 25, 2024 21:05
.github/scripts/Install-Vsix.ps1 Show resolved Hide resolved
.github/scripts/Install-Vsix.ps1 Outdated Show resolved Hide resolved
.github/scripts/Install-Vsix.ps1 Outdated Show resolved Hide resolved
Build-SampleSet.ps1 Outdated Show resolved Hide resolved
.github/scripts/Install-Vsix.ps1 Outdated Show resolved Hide resolved
@middlemose
Copy link
Contributor Author

Building samples locally passed.

Build Environment:          NuGet
Build Number:               26100
Nuget Package Version:      10.0.26100.1
WDK VSIX Version:           10.0.26100.1
Samples:                    132
Configurations:             2 (Debug Release)
Platforms:                  2 (x64 arm64)
InfVerif_AdditionalOptions: /samples
Combinations:               528
LogicalProcessors:          20
ThrottleFactor:             5
ThrottleLimit:              100
WDS_WipeOutputs:
Disk Remaining (GB):        742.531757354736
Built all combinations.

Elapsed time:         13 minutes, 17 seconds.
Disk Remaining (GB):  734.718753814697
Samples:              132
Configurations:       2 (Debug Release)
Platforms:            2 (x64 arm64)
Combinations:         528
Succeeded:            526
Excluded:             0
Unsupported:          2
Failed:               0
Sporadic:             0
Log files directory:  D:\my_stuff\Windows-driver-samples\_logs
Overview report:      D:\my_stuff\Windows-driver-samples\_logs\_overview.htm

_overview.csv

@NeoAdonis NeoAdonis dismissed JakobL-MSFT’s stale review June 27, 2024 23:08

Requested changes were resolved but reviewer is unavailable to approve at this moment

@NeoAdonis NeoAdonis merged commit 77a4528 into microsoft:develop Jun 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants