Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New templates adding Microsoft copyright notice #3143

Closed
JaiganeshKumaran opened this issue Nov 14, 2022 · 4 comments · Fixed by #3324
Closed

New templates adding Microsoft copyright notice #3143

JaiganeshKumaran opened this issue Nov 14, 2022 · 4 comments · Fixed by #3324
Assignees
Labels
area-Infrastructure Build, test, source layout, package construction (TODO: move to Deployment, DeveloperTools) bug Something isn't working Status: Fixed

Comments

@JaiganeshKumaran
Copy link
Contributor

Describe the bug

New 1.2 project and item templates are adding Microsoft copyright and MIT License notice to every file, which it shouldn't have as the templates are used to create your own project which isn't copyrighted by Microsoft.

Steps to reproduce the bug

  1. Create a new WinUI 3 project or item.
  2. See the unnecessary copyright message.
<!-- Copyright (c) Microsoft Corporation. All rights reserved. -->
<!-- Licensed under the MIT License. See LICENSE in the project root for license information. -->

Expected behavior

No response

Screenshots

No response

NuGet package version

No response

Packaging type

No response

Windows version

No response

IDE

Visual Studio 2022-preview

Additional context

Templates version: 1.2.220902.1 (installed automatically by Visual Studio Installer).

@gabbybilka gabbybilka added bug Something isn't working area-Infrastructure Build, test, source layout, package construction (TODO: move to Deployment, DeveloperTools) labels Nov 17, 2022
@CodePagesNet
Copy link

Yes, upvoted and I find this copyright notice in one's own project code to be confusing. Request explanation, or please remove the copyright notice, the latter being preferable. Thank You.

@bpulliam bpulliam linked a pull request Jan 11, 2023 that will close this issue
@michael-hawker
Copy link

@bpulliam I still saw this creating a new project today, how do updates to the template ship? When should folks expect to see this change hit their boxes? Thanks!

@duncanmacmichael
Copy link
Member

This issue has been fixed in 1.2.4.

@theinas
Copy link

theinas commented Jul 18, 2023

@duncanmacmichael I don't this issue has been entirely fixed. Updated today to 1.3.2 and I am still seeing the copy rights messages whenever creating a WinUI item

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Infrastructure Build, test, source layout, package construction (TODO: move to Deployment, DeveloperTools) bug Something isn't working Status: Fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants