-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App, process, and crash dump collection APIs #193
Conversation
Hi @hpsin, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
BugcheckSettingsApi, | ||
string.Format( | ||
"autoreboot={0}&overwrite={1}&dumptype={2}&maxdumpcount={3}", | ||
dfs.AutoReboot ? "1" : "0", dfs.Overwrite ? "1" : "0", (int)dfs.DumpType, dfs.MaxDumpCount)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a Utilities.BuildQueryString in the project that you can use to format this stuff (takes a dictionary of name/value pairs and formats them with the & and = signs). This seems clear enough though, so I'd be fine either way.
* DeviceLab sample * This is what I showed to Dave * Committing so that I can change machines and not loose my work * Added a bunch of finishing touches * Latest polish * Added a nifty CommandSequence class * Implemented a nifty CommandSequence class and then used it for the DevicePortalCommand model * Code cleanup + style cop. Checking in for demo * Finished satisfyint StyleCop * Committing before merging changes from upstream * Integrated the new DeviceSignIn view. Fixed the timing issue in the reestablish connection retry loop. Made rename more robust. Stronger check for duplicates using the cannonical IP address * Renamed DeviceLab to SampleDeviceCollection * Added finishing touches to the code. Getting it ready for a pull request * Breaking Change: Updating async methods to follow C# async naming conventions (#188) And updating version number. * Update calls into the wrapper to use the latest async naming convention * Not tracking sync.cmd * Ended up with a stray orig file. Deleting * Change array return types to Lists for #189 (#191) * App, process, and crash dump collection APIs (#193) * Add usermode crash dump APIs * Additional fixes to DumpCollection * Add kernel, live, and app dump APIs. * StyleCop pass
This covers #28 - Dump collections not implemented.