Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ado-improvements-1): upgrade to report@4.2.1 package to take advantage of better log output #1031

Merged
merged 1 commit into from Feb 7, 2022

Conversation

karanbirsingh
Copy link
Contributor

Details

This PR consumes the change in microsoft/accessibility-insights-web#5145 so that we no longer see a React warning about missing keys in our execution logs.

Motivation

Addresses part of #950

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Added relevant unit test for your changes. (yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • Ran precheckin (yarn precheckin)
  • (after PR created) The Accessibility Checks (pull_request) check should fail. All other checks should pass.

@karanbirsingh karanbirsingh requested a review from a team as a code owner February 4, 2022 22:24
@karanbirsingh karanbirsingh changed the title feat(ado-improvements-1): upgrade to next report package to take advantage of better log output feat(ado-improvements-1): upgrade to report@4.2.1 package to take advantage of better log output Feb 4, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1031 (27d25e9) into main (57e0a08) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1031   +/-   ##
=======================================
  Coverage   89.69%   89.69%           
=======================================
  Files          44       44           
  Lines        1058     1058           
  Branches      139      139           
=======================================
  Hits          949      949           
  Misses        109      109           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57e0a08...27d25e9. Read the comment docs.

@karanbirsingh karanbirsingh merged commit c9a8d98 into main Feb 7, 2022
@karanbirsingh karanbirsingh deleted the karan/consume-report branch February 7, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants