feat(ado-ext-telemetry): Grouping rarely used options under Advanced Options group #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
dbjorge
approved these changes
Mar 18, 2022
1 task
dbjorge
added a commit
that referenced
this pull request
Apr 15, 2022
…1139) #### Details PR #1092 added `outputDir` and `chromePath` to a new "Advanced Options" group. PR #1122 accidentally reverted the group from `chromePath` - this PR un-reverts it and moves `chromePath` back to "Advanced Options". ##### Motivation Match feature spec ##### Context n/a #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [n/a] Addresses an existing issue: Fixes #0000 - [n/a] Added relevant unit test for your changes. (`yarn test`) - [n/a] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] Ran precheckin (`yarn precheckin`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This introduces an advanced options group to the pipeline configuration assistant UI in ADO. It groups the
outputDirandchromePathoptions under a collapsed by default group calledAdvanced Optionsthat shows up at the bottom of the UI.Here is what it looks like collapsed:
Here it is expanded:
Motivation
Partially addresses #1063
Context
We will need to add
artifactNameto the advanced options once #1085 has been merged. I'll add this in a separate commit after merging that PR into main.Pull request checklist
yarn test)<rootDir>/test-results/unit/coverageyarn precheckin)Accessibility Checks (pull_request)check should fail. All other checks should pass.