chore: create self-test workflow to run in main #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karanbirsingh
approved these changes
Mar 28, 2022
1 task
dbjorge
added a commit
that referenced
this pull request
Mar 28, 2022
#### Details This is a followup to #1110 which fixes a half-reverted change I'd been trying out to use a matrix of node versions to test with ##### Motivation Fixes https://github.com/microsoft/accessibility-insights-action/runs/5726695339?check_suite_focus=true ##### Context see #1110 #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [n/a] Addresses an existing issue: Fixes #0000 - [n/a] Added relevant unit test for your changes. (`yarn test`) - [n/a] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] Ran precheckin (`yarn precheckin`)
1 task
dbjorge
added a commit
that referenced
this pull request
Mar 28, 2022
#### Details The self test workflow added today in #1110 and #1111 uncovered issue #1112 when I tried to use a matrix strategy to test it across both ubuntu and windows agents. This PR disables the matrix strategy as a workaround until we fix #1112. ##### Motivation Unblock self-test workflow ##### Context n/a #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [n/a] Addresses an existing issue: Fixes #0000 - [n/a] Added relevant unit test for your changes. (`yarn test`) - [n/a] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] Ran precheckin (`yarn precheckin`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
We used to run a self-test of the GitHub action in our PR/CI builds, but disabled it due to #629 preventing it from working in PR builds.
However, I think it would still be valuable to run in CI builds against main, even if we can't run it with PRs yet. This restores it in a separate workflow that only triggers on pushes to main (not PRs).
Motivation
Maintain ongoing validation that we haven't broken the action.
Context
n/a
Pull request checklist
yarn test)<rootDir>/test-results/unit/coverageyarn precheckin)