Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update publishing pipelines to use federated credentials instead of PATs and client secrets #2082

Merged
merged 54 commits into from
May 20, 2024
Merged

chore: update publishing pipelines to use federated credentials instead of PATs and client secrets #2082

merged 54 commits into from
May 20, 2024

Commits on Apr 18, 2024

  1. Update Create ESRP service connection.yml 

    Add task to get service principal id for later step
    @madalynrose
    madalynrose committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    540e472 View commit details
    Browse the repository at this point in the history

  2. Update Create ESRP service connection.yml 

    change azureSubscription from service principal name to service connection name
    @madalynrose
    madalynrose committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    5d73212 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. Update Create ESRP service connection.yml 

    use newer version of azure cli
    @madalynrose
    madalynrose committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    ed904c7 View commit details
    Browse the repository at this point in the history

  2. Update Create ESRP service connection.yml 

    v3 doesn't exist, change it back and instead assign Reader role to managed identity
    @madalynrose
    madalynrose committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    9923e7a View commit details
    Browse the repository at this point in the history

  3. Update Create ESRP service connection.yml 

    attempt to generate the access token and set the PAT env variable
    @madalynrose
    madalynrose committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    3256ada View commit details
    Browse the repository at this point in the history

  4. Update Create ESRP service connection.yml 

    remove azureSubscription from ps task
    @madalynrose
    madalynrose committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    90ecc94 View commit details
    Browse the repository at this point in the history

  5. Update Create ESRP service connection.yml 

    dedent stuff in ps task
    @madalynrose
    madalynrose committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    b54c40b View commit details
    Browse the repository at this point in the history

  6. Update Create ESRP service connection.yml 

    attempt to fix indentation again
    @madalynrose
    madalynrose committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    5667172 View commit details
    Browse the repository at this point in the history

  7. actually fix indends

    @madalynrose
    madalynrose committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    3b30591 View commit details
    Browse the repository at this point in the history

  8. pass pat env variable to ps task

    @madalynrose
    madalynrose committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    453daa8 View commit details
    Browse the repository at this point in the history

  9. print env variables to check values

    @madalynrose
    madalynrose committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    18df31b View commit details
    Browse the repository at this point in the history

  10. use isoutput

    @madalynrose
    madalynrose committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    b3e308e View commit details
    Browse the repository at this point in the history

  11. print pat to make sure it's set

    @madalynrose
    madalynrose committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    eee8f35 View commit details
    Browse the repository at this point in the history

  12. move write host up

    @madalynrose
    madalynrose committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    e2b8f1b View commit details
    Browse the repository at this point in the history

  13. try isoutput again

    @madalynrose
    madalynrose committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    9443079 View commit details
    Browse the repository at this point in the history

  14. access env variable through env:

    @madalynrose
    madalynrose committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    6ad27f0 View commit details
    Browse the repository at this point in the history

  15. try adding access token stuff for vsix publishing

    @madalynrose
    madalynrose committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    0048aab View commit details
    Browse the repository at this point in the history

  16. dedent env variables

    @madalynrose
    madalynrose committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    8411a12 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. check project access with readonly command

    @madalynrose
    madalynrose committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    f07bf9b View commit details
    Browse the repository at this point in the history

  2. try explicit login

    @madalynrose
    madalynrose committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    6cef43d View commit details
    Browse the repository at this point in the history

  3. allow-no-subscriptions

    @madalynrose
    madalynrose committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    5fcc773 View commit details
    Browse the repository at this point in the history

  4. let it login with the PAT

    @madalynrose
    madalynrose committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    f2373bf View commit details
    Browse the repository at this point in the history

  5. try using explicit managed id to logihn

    @madalynrose
    madalynrose committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    ed8d566 View commit details
    Browse the repository at this point in the history

  6. try without federated token

    @madalynrose
    madalynrose committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    f282f66 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. try to login with service principal and federated token

    @madalynrose
    madalynrose committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    96f3a79 View commit details
    Browse the repository at this point in the history

  2. move SP id to variable

    @madalynrose
    madalynrose committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    4d4a15d View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. update signing task to use v5

    @madalynrose
    madalynrose committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    668950c View commit details
    Browse the repository at this point in the history

  2. try with different task name

    @madalynrose
    madalynrose committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    d9d4fe5 View commit details
    Browse the repository at this point in the history

  3. use .net core 6.0.x

    @madalynrose
    madalynrose committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    4a24219 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. use 1ES Hosted pools

    @madalynrose
    madalynrose committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    5ec2c97 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. try using demands

    @madalynrose
    madalynrose committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    29a86b3 View commit details
    Browse the repository at this point in the history

  2. specify pool in release template

    @madalynrose
    madalynrose committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    86cfa7f View commit details
    Browse the repository at this point in the history

  3. undo that change

    @madalynrose
    madalynrose committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    90bb24b View commit details
    Browse the repository at this point in the history

  4. back to ubuntu-latest

    @madalynrose
    madalynrose committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    371e032 View commit details
    Browse the repository at this point in the history

  5. use name image os again

    @madalynrose
    madalynrose committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    a3d1c1e View commit details
    Browse the repository at this point in the history

  6. try with vmImage and demands

    @madalynrose
    madalynrose committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    9c449cc View commit details
    Browse the repository at this point in the history

  7. demand agent by name

    @madalynrose
    madalynrose committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    2702c90 View commit details
    Browse the repository at this point in the history

  8. specify in stages

    @madalynrose
    madalynrose committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    2a5cbd8 View commit details
    Browse the repository at this point in the history

  9. try ubuntu-20.04

    @madalynrose
    madalynrose committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    59502f8 View commit details
    Browse the repository at this point in the history

  10. surround image name in quotes

    @madalynrose
    madalynrose committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    98b4a3d View commit details
    Browse the repository at this point in the history

  11. specify in job, use variable

    @madalynrose
    madalynrose committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    0a43e29 View commit details
    Browse the repository at this point in the history

  12. use variable in release-template.yml too

    @madalynrose
    madalynrose committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    d266c88 View commit details
    Browse the repository at this point in the history

  13. specify in more places

    @madalynrose
    madalynrose committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    87ebee3 View commit details
    Browse the repository at this point in the history

  14. remove from wrong spot

    @madalynrose
    madalynrose committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    28334b8 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. add imageoverride

    @madalynrose
    madalynrose committed May 8, 2024
    Configuration menu
    Copy the full SHA
    2d41833 View commit details
    Browse the repository at this point in the history

  2. add imageoverride in release template

    @madalynrose
    madalynrose committed May 8, 2024
    Configuration menu
    Copy the full SHA
    2663f42 View commit details
    Browse the repository at this point in the history

  3. generate access token for QueryVersion task

    @madalynrose
    madalynrose committed May 8, 2024
    Configuration menu
    Copy the full SHA
    4df5cc4 View commit details
    Browse the repository at this point in the history

  4. save reused task as template

    @madalynrose
    madalynrose committed May 8, 2024
    Configuration menu
    Copy the full SHA
    db0f6b3 View commit details
    Browse the repository at this point in the history

  5. grab resource id from variables

    @madalynrose
    madalynrose committed May 8, 2024
    Configuration menu
    Copy the full SHA
    b337efd View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. remove pipeline that creates new ESRP service connection

    @madalynrose
    madalynrose committed May 9, 2024
    Configuration menu
    Copy the full SHA
    657a7fa View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/microsoft/accessibility-ins… 

    …ights-action into fix-esrp-signing-v5
    @madalynrose
    madalynrose committed May 9, 2024
    Configuration menu
    Copy the full SHA
    14355ab View commit details
    Browse the repository at this point in the history

  3. use correct image specification format for prod

    @madalynrose
    madalynrose committed May 9, 2024
    Configuration menu
    Copy the full SHA
    eafae1f View commit details
    Browse the repository at this point in the history

  4. use variables for client and tenant id in ESRP signing task

    @madalynrose
    madalynrose committed May 9, 2024
    Configuration menu
    Copy the full SHA
    2257ba4 View commit details
    Browse the repository at this point in the history

  5. add clarifying comment about plaintext guid

    @madalynrose
    madalynrose committed May 9, 2024
    Configuration menu
    Copy the full SHA
    89c2eb9 View commit details
    Browse the repository at this point in the history