Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rearrange dependencies and devDependencies #232

Merged
merged 2 commits into from
Aug 26, 2020

Conversation

pownkel
Copy link
Contributor

@pownkel pownkel commented Aug 26, 2020

Description of changes

Make sure we have the packages in the right section of package.json (either dependencies or devDependencies) so we can generate an accurate NOTICE file

Pull request checklist

  • Addresses an existing issue: Repo needs third-party notices file #223
  • Added relevant unit test for your changes. (yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • Ran precheckin (yarn precheckin)

@pownkel pownkel requested a review from a team as a code owner August 26, 2020 21:41
@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2020

Codecov Report

Merging #232 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #232   +/-   ##
=======================================
  Coverage   95.83%   95.83%           
=======================================
  Files          20       20           
  Lines         408      408           
  Branches       23       23           
=======================================
  Hits          391      391           
  Misses         17       17           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8203c31...17d06af. Read the comment docs.

@pownkel pownkel merged commit 26ee743 into master Aug 26, 2020
@pownkel pownkel deleted the pownkel/dependencies branch August 26, 2020 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants