Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(axe-core-4.2.1): update axe-core, ai-scan, and ai-report packages together #628

Merged
merged 2 commits into from May 25, 2021

Conversation

dbjorge
Copy link
Contributor

@dbjorge dbjorge commented May 25, 2021

Details

Updates axe-core, accessibility-insights-scan, and accessibility-insights-report packages together to match versions in use in web/service.

Motivation

Keep action ruleset synced with web/service

Context

n/a

Pull request checklist

  • [n/a] Addresses an existing issue: Fixes #0000
  • [n/a] Added relevant unit test for your changes. (yarn test)
  • [n/a] Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • Ran precheckin (yarn precheckin)
  • (after PR created) The Accessibility Checks (pull_request) check should fail. All other checks should pass.

@dbjorge dbjorge requested a review from a team as a code owner May 25, 2021 21:04
@github-actions
Copy link
Contributor

Accessibility Insights Accessibility Insights Action

  • URLs: 1 URL(s) failed, 3 URL(s) passed, and 0 were not scannable
  • Rules: 5 check(s) failed, 11 check(s) passed, and 39 were not applicable
  • Download the Accessibility Insights artifact to view the detailed results of these checks

Failed instances

  • 3 × label: Ensures every form element has a label
  • 1 × html-has-lang: Ensures every HTML document has a lang attribute
  • 1 × image-alt: Ensures elements have alternate text or a role of none or presentation

This scan used axe-core 4.2.1 with Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.75 Safari/537.36.

@dbjorge
Copy link
Contributor Author

dbjorge commented May 25, 2021

Note: the checks section shows "all checks have passed" incorrectly due to #631 in combination with #629

@dbjorge dbjorge merged commit 4f43a9a into main May 25, 2021
@dbjorge dbjorge deleted the axe-core-4.2.1 branch May 25, 2021 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants