Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

fix: use get localhost instead of loopback address #12

Merged
merged 1 commit into from
Mar 19, 2020

Conversation

waabid
Copy link
Member

@waabid waabid commented Mar 13, 2020

Description of changes

Validated with emulated device on OS 26 and OS 24.

Pull request checklist

  • [n/a] Addresses an existing issue: #0000
  • [n/a] Added/updated relevant unit test(s)
  • Ran ./gradlew fastpass from AccessibilityInsightsForAndroidService
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:).

@waabid waabid requested a review from a team as a code owner March 13, 2020 23:57
@jalkire
Copy link
Contributor

jalkire commented Mar 17, 2020

Are the XML file changes related to the change in SDK version?

Copy link
Contributor

@jalkire jalkire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one not too important question

@waabid
Copy link
Member Author

waabid commented Mar 19, 2020

Are the XML file changes related to the change in SDK version?

Yep! They are from the compile version changing.

@waabid waabid merged commit 6765c71 into microsoft:master Mar 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants