Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(axe-core-4.6): Update to axe-core 4.6.3, enabling link-in-text-block, meta-viewport, and "Related paths" in reports #2383

Merged
merged 7 commits into from
Feb 2, 2023

Conversation

dbjorge
Copy link
Contributor

@dbjorge dbjorge commented Feb 2, 2023

Details

This PR:

  • Updates axe-core to v4.6.3
  • Updates accessibility-insights-report to corresponding v4.6.3
  • Removes link-in-text-block and meta-viewport from the rule exclusion list, matching the new AI4Web behavior enabling them as automated checks
  • Enables a new report feature to include "Related paths" for failure cards of axe results with "relatedNodes" info by propogating this axe property in combined-report-data-converter.ts
  • Bumps the accessibility-insights-scan minor version to 1.6.0 in anticipation of a corresponding release for that package

Screenshot of combined report segment with new Related paths UX generated using the following CLI command in this PR branch: node C:\repos\accessibility-insights-service\packages\cli\dist\ai-scan-cli.js --crawl --url https://developer.microsoft.com/en-us/fluentui#/controls/web/detailslist --maxUrls 5

screenshot highlighting new "Related paths" field in a failure card in a combined report

Motivation

Keep service rules version in sync with AI4Web, which has begun release validation today for its corresponding release (2.37.0)

Context

Pull request checklist

  • Addresses an existing issue: 2017450
  • Added relevant unit test for your changes. (yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • Ran precheckin (yarn precheckin)
  • Validated in an Azure resource group

@dbjorge dbjorge requested a review from a team as a code owner February 2, 2023 21:47
@dbjorge dbjorge merged commit 49d163b into microsoft:main Feb 2, 2023
@dbjorge dbjorge deleted the axe-core-4.6.3 branch February 2, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants