Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No links to needs-review doc pages? #7007

Open
DaveTryon opened this issue Oct 6, 2023 · 0 comments
Open

No links to needs-review doc pages? #7007

DaveTryon opened this issue Oct 6, 2023 · 0 comments
Assignees
@v-sharmachir
Labels
bug Something isn't working status: active This issue is currently being worked on by someone.

Comments

@DaveTryon
Copy link
Contributor

Describe the bug

None of the needs-review document pages are referenced anywhere inside the web extension. Some of the rules that show up in the Needs review tab link to their counterparts of Automated checks document pages.

Specifically:

Expected behavior

Since these pages exist to add more detail on fixing these issues, I'd expect the pages to be used as reference material by the web extension

Screenshots

Are you willing to submit a PR?

Did you search for similar existing issues?

Additional context
@DaveTryon DaveTryon added the bug Something isn't working label Oct 6, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the status: new This issue is new and requires triage by DRI. label Oct 6, 2023
v-sharmachir added a commit to v-sharmachir/accessibility-insights-web that referenced this issue Dec 4, 2023
@v-sharmachir
fIx : No links to needs-review doc pages? microsoft#7007
5660540
@v-sharmachir v-sharmachir mentioned this issue Dec 5, 2023
Merged
5 tasks
@v-viyada v-viyada added the status: active This issue is currently being worked on by someone. label Dec 5, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot removed the status: new This issue is new and requires triage by DRI. label Dec 5, 2023
v-sharmachir added a commit that referenced this issue Feb 5, 2024
@v-sharmachir
fix: No links to needs-review doc pages? #7007 (#7133)
b0ec9a0 
#### Details
Bug fix to use needs-review document pages for the Needs review tab
link. None of the needs-review document pages were referenced anywhere
inside the web extension. Some of the rules that show up in the Needs
review tab link have document page available but the url under needs
review were of either automated check rule url.

The fix used is, In the rule-resources.tsx file we are checking if the
tab selected is needs-review on the basis of the outcome type and added
a new file named needs-review-rule-resources.tsx is used to create the
needs review url on the basis of rules present in the document page.

![Screenshot 2023-12-07
191019](https://github.com/microsoft/accessibility-insights-web/assets/150002431/24e3769e-ad5a-4a0b-aed8-babc9e4ae31d)


##### Motivation

fix: No links to needs-review doc pages? #7007

##### Context

#### Pull request checklist
- [x] Addresses an existing issue: #7007
- [x] Ran `yarn fastpass`
- [x] Added/updated relevant unit test(s) (and ran `yarn test`)
- [x] Verified code coverage for the changes made. Check coverage report
at: `<rootDir>/test-results/unit/coverage`
- [x] PR title *AND* final merge commit title both start with a semantic
tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See
`CONTRIBUTING.md`.
- [NA] (UI changes only) Added screenshots/GIFs to description above
- [NA] (UI changes only) Verified usability with NVDA/JAWS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@v-sharmachir v-sharmachir

Labels
bug Something isn't working status: active This issue is currently being worked on by someone.
Projects
Accessibility Insights
Status: Needs release
Milestone
No milestone
Development

No branches or pull requests
4 participants
@madalynrose @DaveTryon @v-viyada @v-sharmachir