Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve user messages when connecting Android device #3664

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

DaveTryon
Copy link
Contributor

@DaveTryon DaveTryon commented Nov 17, 2020

Description of changes

This makes the text changes called out in #3542. Here are the before and after images:

Screen Before After
Connect Device image image
Grant Permissions image image

Pull request checklist

  • Addresses an existing issue: Add additional instructions in the 'Connect to your Android device' / 'Connect to Service' screens #3542
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • (UI changes only) Added screenshots/GIFs to description above
  • (UI changes only) Verified usability with NVDA/JAWS

@DaveTryon DaveTryon requested a review from a team as a code owner November 17, 2020 21:41
@DaveTryon
Copy link
Contributor Author

@LiLoDavis and @ferBonnin, do the attached visuals match your expectations?

@ferBonnin
Copy link
Contributor

@LiLoDavis and @ferBonnin, do the attached visuals match your expectations?

yes, thanks @DaveTryon!

@DaveTryon DaveTryon merged commit 420d6de into microsoft:master Nov 17, 2020
@DaveTryon DaveTryon deleted the UpdateConnectText branch November 18, 2020 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants