fix: Make "Expand all" button more screen-reader friendly #3665
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue #3539 suggests an improvement to the Expand all/Collapse all button when read via a screen reader. Specifically, set the aria-label property to a more descriptive value when the button is in the collapsed state. The issue says nothing about modifying the aria-label property in the expanded state. Change has been validated with NVDA in both Web and Unified clients.
HTML of the button in the collapsed state (aria-label property is new)
HTML of the button in the expanded state (no aria-label is added, and button is unchanged from before):
Pull request checklist
yarn fastpass
yarn test
)<rootDir>/test-results/unit/coverage
fix:
,chore:
,feat(feature-name):
,refactor:
). SeeCONTRIBUTING.md
.