Re-factor assessment store to inject the initialAssessmentStoreDataGenerator dependency #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoralesd
reviewed
Mar 27, 2019
smoralesd
reviewed
Mar 27, 2019
waabid
reviewed
Mar 28, 2019
markreay
previously requested changes
Mar 29, 2019
…ers/haonliu/assessment-store-refactor
waabid
reviewed
Mar 29, 2019
| const assessmentData = config.getAssessmentData(this.state); | ||
| if (assessmentData.generatedAssessmentInstancesMap == null) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
This change is not absolutely necessary in this PR but I figured to make it since I was working within the test for this and found it odd that it was not behaving per whatever was sent in the payload. Since this is hidden behind a non-public feature flag, I would feel comfortable moving forward with this.
…reated/persisted data
waabid
changed the title
smoralesd
reviewed
Mar 29, 2019
| @@ -27,6 +28,9 @@ const assessmentWithColumns: Assessment = { | |||
| title: 'assessment 1', | |||
| gettingStarted: null, | |||
| guidance: content.assessment1.guidance, | |||
| initialDataCreator: () => { | |||
There was a problem hiding this comment.
does it make sense to extract this function?
smoralesd
previously approved these changes
Mar 29, 2019
Shobhit1
previously approved these changes
Mar 29, 2019
dbjorge
reviewed
Mar 29, 2019
src/tests/unit/tests/background/initial-assessment-store-data-generator.test.ts
Outdated
Show resolved
Hide resolved
dbjorge
reviewed
Mar 29, 2019
...sts/unit/tests/background/__snapshots__/initial-assessment-store-data-generator.test.ts.snap
Outdated
Show resolved
Hide resolved
dbjorge
approved these changes
Mar 29, 2019
smoralesd
approved these changes
Mar 29, 2019
waabid
added
the
pr: auto-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
npm run test)<rootDir>/test-results/unit/coveragenpm run precheckin)Description of changes
Since a lot of tests are dependent on assessment store data builder, we have to make changes to many tests to ensure that they don't break. A lot of them are dependent on some state being given by the store data builder so we've gone with an internal mock approach, although not fully ideal, to return the state as expected.