Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to yarn v3 #6519

Merged
merged 9 commits into from Mar 22, 2023
Merged

chore: migrate to yarn v3 #6519

merged 9 commits into from Mar 22, 2023

Conversation

dbjorge
Copy link
Contributor

@dbjorge dbjorge commented Mar 17, 2023

Details

Migrates the repo's package manager from yarn v1 to yarn v3 (in non-zero-installs configuration)

Some of this was mechanical based on Yarn's migration guide. Beyond the steps there, this PR:

  • Updates assorted CI pipelines/workflows and dev docs to adapt to minor syntax updates
  • Updates CI workflow's caching strategy to use actions/setup-node@v3's built-in support for yarn berry friendly caching instead of implementing our own with actions/cache@v3
  • Updates license-check-and-add and prettier configs to exclude .yarn/
  • Updates e2e Dockerfile to account for new changes
  • Drops Lerna dependency in favor of plain Yarn workspaces, similar to service and action
Motivation
  • Simplifies some common dev commands. In particular, the command to update report package snapshots changes from yarn test:report:e2e -- -- -- -u to just yarn test:report:e2e -u
  • Consistency with other repos
  • Allows for versioned resolutions (similar to chore: clean up yarn resolutions using versioned specifiers accessibility-insights-action#1596) - I left modifying existing resolutions out of scope since this PR was already pretty large without them, will cover them in a different PR
  • Removes a dependency (Lerna)
Context

Similar PRs in other repos:

Pull request checklist

  • [n/a] Addresses an existing issue: #0000
  • Ran yarn fastpass
  • [n/a] Added/updated relevant unit test(s) (and ran yarn test)
  • [n/a] Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • [n/a] (UI changes only) Added screenshots/GIFs to description above
  • [n/a] (UI changes only) Verified usability with NVDA/JAWS

@dbjorge dbjorge requested a review from a team as a code owner March 17, 2023 21:06
Copy link
Member

@waabid waabid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbjorge dbjorge merged commit 6222eb0 into microsoft:main Mar 22, 2023
@dbjorge dbjorge deleted the yarn-v3 branch March 22, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants