fix: Prevent horizontal shifting in properties grid #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaveTryon
approved these changes
Nov 9, 2022
5 tasks
sfoslund
added a commit
that referenced
this pull request
Nov 10, 2022
#### Details Fix bug in #1475 in which search bar height was not taken into account in vertical scrolling logic. Behavior after this PR: [Description: Gif of AIWin in live inspect mode. User navigates arounds property grid, which has the search bar visible at the top. Navigation is the same as before but horizontal jumps have been removed.]  ##### Motivation Fix bug #### Pull request checklist - [ ] Run through of all [test scenarios](https://github.com/Microsoft/accessibility-insights-windows/blob/main/docs/Scenarios.md) completed? - [ ] Does this address an existing issue? If yes, Issue# - - [x] Includes UI changes? - [ ] Run the production version of Accessibility Insights for Windows against a version with changes. - [x] Attach any screenshots / GIF's that are applicable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
By default when a
ScrollVieweris wrapping aGrid, WPF scrolls to focus on the element being selected in the grid. This is the behavior we want for vertical scrolling, but this causes some jumpy behavior in the horizontal scrollbar, as described in #1150. The horizonal jumps would make more sense if the user were navigating between cells horizontally, but since we treat the properties grid as a list and only allow navigation between rows (as opposed to between cells), the default behavior just looks odd. As a result, this PR overrides WPF default behavior by keeping vertical navigation the same but removing the horizontal component.Motivation
Addresses issue #1150
Context
Behavior after this change:
[Description: Gif of AIWin in live inspect mode. User navigates arounds property grid with keyboard. Navigation is the same as before but horizontal jumps have been removed.]
Pull request checklist