Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Take searchbar height into account for vertical scroll #1478

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

sfoslund
Copy link
Member

@sfoslund sfoslund commented Nov 10, 2022

Details

Fix bug in #1475 in which search bar height was not taken into account in vertical scrolling logic.

Behavior after this PR:
[Description: Gif of AIWin in live inspect mode. User navigates arounds property grid, which has the search bar visible at the top. Navigation is the same as before but horizontal jumps have been removed.]
Accessibility Insights for Windows - Inspect - Live 2022-11-10 14-14-34

Motivation

Fix bug

Pull request checklist

  • Run through of all test scenarios completed?
  • Does this address an existing issue? If yes, Issue# -
  • Includes UI changes?
    • Run the production version of Accessibility Insights for Windows against a version with changes.
    • Attach any screenshots / GIF's that are applicable.

@sfoslund sfoslund requested a review from a team as a code owner November 10, 2022 22:12
Copy link
Contributor

@DaveTryon DaveTryon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 👍

@sfoslund sfoslund merged commit be139d8 into microsoft:main Nov 10, 2022
@sfoslund sfoslund deleted the ScrollBug branch November 10, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants