Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] ControlViewSpinnerStructure should allow ListItem #272

Closed
LiLoDavis opened this issue Apr 8, 2019 · 0 comments
Closed

[BUG] ControlViewSpinnerStructure should allow ListItem #272

LiLoDavis opened this issue Apr 8, 2019 · 0 comments
Labels
bug Something isn't working status: resolved This issue has been merged into main.

Comments

@LiLoDavis
Copy link

Current rule
The given element is expected to have the following structure: Spinner and == 2 and <= 1 and AllChildren(not(IsControlElement) or (Button or Edit)).

Proposed rule
The rule should allow ListItem.
See the documentation: https://docs.microsoft.com/en-us/windows/desktop/winauto/uiauto-supportspinnercontroltype#typical-tree-structure
@msft-github-bot msft-github-bot added the status: new This issue is new and requires triage by DRI. label Apr 8, 2019
@MinKPark MinKPark assigned RobGallo and unassigned Shobhit1 Apr 9, 2019
@MinKPark MinKPark added bug Something isn't working and removed status: new This issue is new and requires triage by DRI. labels Apr 9, 2019
RobGallo added a commit to RobGallo/accessibility-insights-windows that referenced this issue Apr 10, 2019
@RobGallo
Fixed two spinner Content/Control view issues.
8c62a30 
- Issue microsoft#272 ControlViewSpinnerStructure should allow ListItem
- Issue microsoft#268 ContentViewSpinnerStructure should allow ListItem

In both cases, the code now allows for 0 or more ListItem children of the spinner control.

Note: Keen observers of the documentation may notice that list items are permitted only when the Selection control pattern is present, and such a check is not done in this code. This is a shortcoming of several of the content/control view rules. However, since no rules currently check for such patterns, it is not the intent to remedy that as part of this change.

Another such failing is that the children are not actually checked to make sure they have the IsContentElement or IsControlElement properties set to true. This failing is common throughout these rules. And again, there is no intent to remedy that as part of this change.
@RobGallo RobGallo mentioned this issue Apr 10, 2019
Merged
5 tasks
@DaveTryon DaveTryon added the status: resolved This issue has been merged into main. label Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working status: resolved This issue has been merged into main.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Shobhit1 @MinKPark @msft-github-bot @RobGallo @LiLoDavis @DaveTryon