chore: Fix test irregularities #1687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeofdusk
approved these changes
Aug 31, 2023
1 task
DaveTryon
added a commit
to microsoft/axe-windows
that referenced
this pull request
Sep 1, 2023
#### Details Similar to microsoft/accessibility-insights-windows#1687, there are some irregularities in our test decorators. This PR is made up of the following global search & replace operations: - `[TestClass()]` becomes `[TestClass]` - `[TestMethod()]` becomes `[TestMethod]` The extra parentheses on the decorators don't break anything, but they are non-standard and don't add any value. I've confirmed that all unit tests run as expected. ##### Motivation Code consistency ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [ ] Addresses an existing issue: #0000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
I noticed today that the
AppLayoutTestswere not running as expected. In investigating, I found the following, which are fixed in this PR:AppLayoutTests.ClassInitializemethod needs to take aTestContextas a parameter--this is why the tests were being discovered but were not being runTestClass,TestMethod,ClassInitialize, andClassCleanupdecorators aren't intended to have parentheses. They still work with the parentheses, but it is a nonstandard representation. I fixed these wherever I found them (4 test classes)Motivation
Test coverage and consistency
Context
Pull request checklist