Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redis streaming client #250

Merged
merged 2 commits into from Feb 8, 2019

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Feb 6, 2019

Integration tested via:

docker network create redis-test

docker build --target builder -t agogosml -f agogosml/Dockerfile.agogosml agogosml

docker run -d --name redis --rm --network redis-test -p 6379:6379 redis:5-alpine \
  redis-server --requirepass 123456password

docker run -d --rm --network redis-test -it agogosml \
  python -m agogosml.tools.receiver --receiver redis \
  '{"REDIS_URL":"redis://:123456password@redis:6379", "REDIS_CHANNEL":"mychan"}'

docker run -d --rm --network redis-test -it agogosml \
  python -m agogosml.tools.sender --infile README.rst --sender redis \
  '{"REDIS_URL":"redis://:123456password@redis:6379", "REDIS_CHANNEL":"mychan"}'

docker logs -f <id-of-receiver-container>

All Submissions:

  • Have you followed the guidelines in our Contributing document?

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

  • Does your PR follow our Code of Conduct?

  • Have you added an explanation of what your changes do and why you'd like us to include them?

  • Does each method or function "do one thing well"? Reviewers may recommend methods be split up for maintainability and testability.

  • Is this code designed to be testable?

  • Is the code documented well?

  • Does your submission pass existing tests (or update existing tests with documentation regarding the change)?

  • Have you added tests to cover your changes?

  • Have you linted your code prior to submission?

  • Have you updated the documentation and README?

  • Is PII treated correctly? In particular, make sure the code is not logging objects or strings that might contain PII (e.g. request headers).

  • Have secrets been stripped before committing?

@c-w c-w force-pushed the redis branch from 5101bdd to d897794 Feb 6, 2019

@c-w c-w requested review from sayar and BatslyAdams Feb 6, 2019

@c-w c-w force-pushed the redis branch from d897794 to 01a9908 Feb 6, 2019

Add redis streaming client
Integration tested via:

```bash
docker network create redis-test

docker build --target builder -t agogosml -f agogosml/Dockerfile.agogosml agogosml

docker run -d --name redis --rm --network redis-test -p 6379:6379 redis:5-alpine \
  redis-server --requirepass 123456password

docker run -d --rm --network redis-test -it agogosml \
  python -m agogosml.tools.receiver --receiver redis \
  '{"REDIS_URL":"redis://:123456password@redis:6379", "REDIS_CHANNEL":"mychan"}'

docker run -d --rm --network redis-test -it agogosml \
  python -m agogosml.tools.sender --infile README.rst --sender redis \
  '{"REDIS_URL":"redis://:123456password@redis:6379", "REDIS_CHANNEL":"mychan"}'

docker logs -f <id-of-receiver-container>
```

@c-w c-w force-pushed the redis branch from 1f82114 to 052a46c Feb 6, 2019

@cicorias cicorias self-requested a review Feb 8, 2019

@cicorias
Copy link
Member

left a comment

LGTM
image

@@ -1,6 +1,7 @@
confluent-kafka~=0.11
azure-eventhub~=1.2
requests~=2.20
redis~=3.1.0

This comment has been minimized.

Copy link
@cicorias

cicorias Feb 8, 2019

Member

we really should be more specific especially on the 0.x.x versions as with jsonnet that has pulled in a release candidate. eg. we had ~=0.11 -- which allowed a 0.12 rc version that was broken on debian.

@cicorias cicorias merged commit 0d388a8 into master Feb 8, 2019

5 checks passed

agogosml-ci Build #20190208.1 succeeded
Details
agogosml-ci (Agogosml-Build-CI) Agogosml-Build-CI succeeded
Details
agogosml-ci (InputReader-Build-CI) InputReader-Build-CI succeeded
Details
agogosml-ci (OutputWriter-Build-CI) OutputWriter-Build-CI succeeded
Details
license/cla All CLA requirements met.
Details

@cicorias cicorias deleted the redis branch Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.