Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix namespace guidance #547

Merged
merged 1 commit into from
Jun 24, 2024
Merged

fix namespace guidance #547

merged 1 commit into from
Jun 24, 2024

Conversation

mikepizzo
Copy link
Contributor

There has been confusion between onboarding and workload owners on exactly what is/is not allowed and required with respect to multiple namespaces (not surprising since we've circled several times on this). This PR reflects the latest decisions regarding namespace use within MS Graph. Specifically:

  • custom namespaces require aliases, as per ADR-030
  • namespace can support multiple levels below microsoft.graph (as per [ADR-030])
  • meaning of a type name should be unique across namespaces; name need not be unique
  • any change to a custom namespace name is breaking

-require alias, as per [ADR-030](https://microsoft.sharepoint.com/teams/APICouncil/_layouts/OneNote.aspx?id=%2Fteams%2FAPICouncil%2FSiteAssets%2FAPI%20Council%20Notebook&wd=target%28ADRs.one%7CCC35B798-B670-4554-9FCF-1682729EFA23%2FADR-030%20Namespace%20Aliases%7C363534F8-EFBD-4201-9F11-DB02AD5B7FAA%2F%29)
-support multiple levels below microsoft.graph (as per [ADR-030])
-clarify uniqueness across namespaces
-clarify that any change to a custom namespace name is breaking
-add alias to the examples as per above
@mikepizzo mikepizzo requested a review from a team as a code owner June 20, 2024 19:16
Copy link
Contributor

@dkershaw10 dkershaw10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikepizzo mikepizzo merged commit 165393e into vNext Jun 24, 2024
1 check passed
@mikepizzo mikepizzo deleted the Namespace-clarifications branch June 24, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants