making produce and download screenshots optional #11
Conversation
| pilotArgs.push("-u"); | ||
| pilotArgs.push(credentials.username); | ||
| pilotArgs.push("-i"); | ||
| pilotArgs.push(ipaPath); |
There was a problem hiding this comment.
nit:
var pilotArgs = ["upload", "-u", credentials.username, "-i", ipaPath];
|
LGTM |
|
Not sure what's causing it but something broke on the "Publish to TestFlight" task: ##[Error] 2016-06-16T22:04:40.021Z: Unhandled: Unexpected token u |
…s to explicit array definition
…e-vsts-extension into make-produce-optional
|
Seems like "deliver init" is still getting called. :( |
|
Also, can you please update the "Download Screenshots" help string from: "helpMarkDown": "Checking this box will download only your screenshots from iTunes Connect before uploading.", to: "helpMarkDown": "Download latest screenshots from iTunes Connect to replace local ones before uploading.", |
|
Seems like the release task is no longer calling "deliver init". However, we still seem to be an extra deliver call to download screenshots on the promote task. I'll open a new issue to track that one so we can finally close this PR. |
|
Btw I like the "Download Metadata from App Store Listing" option you added but now the "Download Screenshots" one seems redundant. How about we remove the screenshots one and simply leave the metadata one? Also I created #14 but I believe its related to this PR. |
rub8n
force-pushed
the
make-produce-optional
branch
from
aa1a2e5
to
18e1ea0
Compare
rub8n
force-pushed
the
make-produce-optional
branch
from
18e1ea0
to
165716b
Compare
Update the release command to make the App Store entry production and screenshot download user accessible options.
EDIT:
Addresses #10 by removing IPA parsing and just requesting the bundle ID
Addresses #6
@rub8n @shishirx34 @lostintangent
EDIT: PR has been updated to cover a few more things.