Add ipa-resign task to Apple App Store extension #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
December 15, 2016 17:02
madhurig
reviewed
Dec 16, 2016
|
|
||
| if (!files || files.length === 0) { | ||
| throw new Error("No matching file was found with search pattern: " + pattern); | ||
| throw new Error('No matching file was found with search pattern: ' + pattern); |
There was a problem hiding this comment.
Do we need to localize all the strings? I see some are and some are not.
| var provFileRemoveProfile: boolean = tl.getBoolInput("provFileRemoveProfile", false); | ||
| } else if (provisionMethod == 'id') { | ||
| var provIdProfileUuid: string = tl.getInput("provIdProfileUuid", true); | ||
| provFileProfilePath = tl.getPathInput('provFileProfilePath', true, false); |
There was a problem hiding this comment.
We should check for tl.filePathSupplied('provFileProfilePath')
| var signIdIdentity: string = tl.getInput("signIdIdentity", true); | ||
| var signIdUnlockKeychain: boolean = tl.getBoolInput("signIdUnlockKeychain", false); | ||
| var signIdKeychainPassword: string = tl.getInput("signIdKeychainPassword", false); | ||
| signFileP12Path = tl.getPathInput('signFileP12Path', true, false); |
There was a problem hiding this comment.
We should check for tl.filePathSupplied('signFileP12Path')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Additional L0 tests
TODO: Update README.md with details on how to use ipa-resign task (should follow the previous tasks in this regard).