Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes.d.ts type definition is incorrect #1015

Closed
stefan-schweiger opened this issue Sep 18, 2023 · 2 comments
Closed

Crashes.d.ts type definition is incorrect #1015

stefan-schweiger opened this issue Sep 18, 2023 · 2 comments
Labels
next-release Will be included in the upcoming release

Comments

@stefan-schweiger
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch appcenter-crashes@5.0.0 for the project I'm working on.

Type definition does not match the actual code. While I think there should be the possibility for innerExceptions at least for now the type definition should match the actual implementation.

Here is the diff that solved my problem:

diff --git a/node_modules/appcenter-crashes/Crashes.d.ts b/node_modules/appcenter-crashes/Crashes.d.ts
index 9185f12..d5bd12d 100644
--- a/node_modules/appcenter-crashes/Crashes.d.ts
+++ b/node_modules/appcenter-crashes/Crashes.d.ts
@@ -24,10 +24,9 @@ export class ErrorAttachmentLog {
 
 export class ExceptionModel {
   wrapperSdkName: string;
-  innerException: ExceptionModel[];
   type: string;
   message: string;
-  stacktrace: string;
+  stackTrace: string;
   public static createFromError(error: Error): ExceptionModel;
   public static createFromTypeAndMessage(type: string, message: string, stacktrace: string): ExceptionModel;
 }

This issue body was partially generated by patch-package.

@MikhailSuendukov
Copy link
Contributor

Hi @stefan-schweiger and thank you for reaching out to us. I submitted a pull request to fix this.

@MikhailSuendukov MikhailSuendukov added the next-release Will be included in the upcoming release label Oct 13, 2023
@AnatolyPristensky
Copy link
Contributor

Hello @stefan-schweiger, this fix available in new 5.0.1 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next-release Will be included in the upcoming release
Projects
None yet
Development

No branches or pull requests

3 participants