Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo in crashes logging #120

Merged
merged 2 commits into from
Sep 20, 2017
Merged

Fix a typo in crashes logging #120

merged 2 commits into from
Sep 20, 2017

Conversation

dhei
Copy link
Member

@dhei dhei commented Sep 20, 2017

Looks like a copy-and-paste error. "Failed to send onBeforeSending event:" should be "Failed to send onSendingFailed event:".

@msftclas
Copy link

@dhei,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Copy link
Member

@guperrot guperrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn.lock should be ignored from git

@dhei
Copy link
Member Author

dhei commented Sep 20, 2017

@guperrot yarn.lock should be checked into source control according to Yarn docs:

All yarn.lock files should be checked into source control (e.g. git or mercurial). This allows Yarn to install the same exact dependency tree across all machines, whether it be your coworker’s laptop or a CI server.

@dhei dhei merged commit 2dd285f into develop Sep 20, 2017
@dhei dhei deleted the fix/crashes-logging-typo branch September 20, 2017 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants