Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App Center post-build does not override custom URL Scheme #469

Merged
merged 7 commits into from Sep 14, 2020
Merged

App Center post-build does not override custom URL Scheme #469

merged 7 commits into from Sep 14, 2020

Conversation

AnastasiaKubova
Copy link
Contributor

@AnastasiaKubova AnastasiaKubova commented Sep 2, 2020 •
edited by xabldint

Things to consider before you submit the PR:

  • Has CHANGELOG.md been updated?
  • Are the files formatted correctly?
  • Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?

Description

  1. Create a Unity project for iOS
  2. Implement the AppCenter Unity plugin and turn on Distribute feature
  3. Define new URL scheme (ex. "myscheme") in Unity project settings: Player Settings->iOS->Other settings->Configuration section->Supported URL Scheme
  4. Build an iOS project

Current behavior
Info.plist contains only one entry in CFBundleURLTypes array for appcenter-xxxxx.

Expected behavior
Info.plist contains two appcenter-xxxxx and myscheme entries in CFBundleURLTypes array.

Related PRs or issues

AB#82424

@vvechkanov vvechkanov marked this pull request as ready for review September 2, 2020 15:16
MatkovIvan
MatkovIvan previously approved these changes Sep 14, 2020
View reviewed changes
annakocheshkova
annakocheshkova suggested changes Sep 14, 2020
View reviewed changes
Assets/AppCenter/Editor/AppCenterPostBuild.cs Outdated Show resolved Hide resolved
Assets/AppCenter/Editor/AppCenterPostBuild.cs Show resolved Hide resolved
Assets/AppCenter/Editor/AppCenterPostBuild.cs Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@MatkovIvan MatkovIvan merged commit 96bf42c into develop Sep 14, 2020
@MatkovIvan MatkovIvan deleted the fix/add-custom-schemes branch September 14, 2020 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatkovIvan MatkovIvan MatkovIvan approved these changes

@annakocheshkova annakocheshkova annakocheshkova approved these changes

@olmisa olmisa olmisa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AnastasiaKubova @MatkovIvan @annakocheshkova @olmisa @vvechkanov