React Native Expo Support #7 #25
Conversation
siyuniu-ms
changed the title
| uniqueIdPromiseTimeout: 5000 | ||
| }); | ||
|
|
||
| export class ReactNativeBasePlugin extends BaseTelemetryPlugin { |
There was a problem hiding this comment.
I was originally thinking that we would have a base class and then 2 implementation classes (the existing and one that didn't set the device info) -- but this works.
The only issue I can think of is that "generally" you would not expect to create and use "Base" classes instances in an application....
We can probably "fix" this by just changing the name of this class to something that doesn't contain Base (or doesn't read like it's a support class that should not be directly used).
Some possible options that come to mind (as we can't change the original without causing bigger breaking changes)
- ReactNativeDefaultPlugin
- ReactNativeNoDevicePlugin
- ReactNativePluginNoDeviceInfo
- ReactNativeManualDevicePlugin
etc, I'm open to other suggestions
There was a problem hiding this comment.
I like ReactNativeManualDevicePlugin~
|
|
||
| protected getDeviceInfoModule(_deviceInfoModule): IDeviceInfoModule { | ||
| if (!_deviceInfoModule) { | ||
| console.log("ReactNativePlugin: Please provide device-info"); |
There was a problem hiding this comment.
We generally don't emit directly to the console, so we should use something like the following
_warnToConsole(_self.diagLog(), "Failed to get DeviceInfo: " + getExceptionName(e) + " - " + dumpObj(e));
And because this will be automatically called as part of the collecting the device, it should also mention that they can disable this by the disableDeviceCollection
MSNev
changed the title
No description provided.