Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to React-Native 0.69.x #4 #5

Merged
merged 1 commit into from
Aug 1, 2022
Merged

Update to React-Native 0.69.x #4 #5

merged 1 commit into from
Aug 1, 2022

Conversation

MSNev
Copy link
Contributor

@MSNev MSNev commented Jul 29, 2022

  • ReactNative requires React 18
  • Updated to support latest for react-native-device-info
  • Added abstraction for DeviceInfoModule to disconnect from the hard react-native-device-info requirement
  • Added test coverage (web based) for DeviceInfoModule abstraction
  • Updated dependencies

// Provide the public interface methods for accessing the values
_self.getModel = _getModel;
_self.getDeviceType = _getDeviceType;
_self.getUniqueId = _getUniqueId

Check notice

Code scanning / CodeQL

Semicolon insertion

Avoid automated semicolon insertion (90% of all statements in [the enclosing function](1) have an explicit semicolon).
- ReactNative requires React 18
- Updated to support latest for `react-native-device-info`
- Added abstraction for DeviceInfoModule to disconnect from the hard `react-native-device-info` requirement
- Added test coverage (web based) for DeviceInfoModule abstraction
- Updated dependencies
@MSNev MSNev added this to the 2.6.0 milestone Aug 1, 2022
@MSNev MSNev merged commit 2b5f615 into main Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants