Create CMakeLists.txt #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First CMake build file, necessary for UWP support because Arcana's UWP offerings aren't header-only.
@syntheticmagus If memory serves, it shouldn't be too much work to make it header-only, which would also make it considerably more portable and easy to consume. |
|
@ryantrem That makes sense, I'm just not sure quite yet that we want to go down that road. We should probably convert the existing code to be header-only -- I'll open an issue for that -- but even after that we may add additional non-header-only capabilities, or we might need a CMakeLists.txt if we want to make the tests cross-plat. It's pretty easy to consume through CMake, too, though certainly not as easy as a truly header-only library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First CMake build file, necessary for UWP support because Arcana's UWP offerings aren't header-only.