Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing archai/devops workflow #138

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Fixing archai/devops workflow #138

merged 1 commit into from
Jan 6, 2023

Conversation

luisffranca
Copy link
Contributor

@luisffranca luisffranca commented Jan 5, 2023

Description

requirements.txt

  • Changed scikit-image version to match Python 3.6

upload.py

  • Resource not found when uploading a model. Fixed by using update_status_entity();
  • Node column in Azure Table was populated with the local machine's name, locking the workflow. Fixed by using update_status_entity()

runner.py

  • All rows are getting skipped due to: skip for now until other quantization finishes on our node. Although the model is already quantized, the column is not set as true. Fixed by correcting the logic of quantization verification.
  • When there's a conversion error (e.g. onnx to dlc), the next state of the Azure Table does not reflect that. It gets stuck on "quantizing" or other unrelated status. Fixed by adding error checks.

Changes

  • Bug fix (non-breaking change which fixes an issue)

Copy link
Member

@lovettchris lovettchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@luisffranca luisffranca merged commit 505406e into main Jan 6, 2023
@luisffranca luisffranca deleted the fix-devops-workflow branch January 6, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants